Address PR comments: remove redundant checks and unnecessary nullptr checks

Co-authored-by: dthaler <[email protected]>

Author: 2 people

tests/api_test/api_test.cpp

@@ -1691,7 +1691,6 @@ TEST_CASE("ebpf_type_conversion_apis", "[ebpf_api]")
     const char* retrieved_name = ebpf_get_program_type_name(&program_type);
     REQUIRE(retrieved_name != nullptr);
     REQUIRE(std::string(retrieved_name) == "bind");
-    REQUIRE(strlen(retrieved_name) > 0);
 }
 
 // Test path canonicalization API.
@@ -1744,9 +1743,7 @@ TEST_CASE("ebpf_enumerate_programs", "[ebpf_api]")
         }
 
         // Clean up error message if any.
-        if (error_message != nullptr) {
-            ebpf_free_string(error_message);
-        }
+        ebpf_free_string(error_message);
     }
 
     // Test with non-existent file - should fail gracefully.
@@ -1756,9 +1753,7 @@ TEST_CASE("ebpf_enumerate_programs", "[ebpf_api]")
     REQUIRE(result != EBPF_SUCCESS);
 
     // Clean up error message if any.
-    if (error_message != nullptr) {
-        ebpf_free_string(error_message);
-    }
+    ebpf_free_string(error_message);
 }
 
 // Test eBPF verification APIs.
@@ -1787,12 +1782,8 @@ TEST_CASE("ebpf_verification_apis", "[ebpf_api]")
         REQUIRE(result == 0);
 
         // Clean up strings.
-        if (report != nullptr) {
-            ebpf_free_string(report);
-        }
-        if (error_message != nullptr) {
-            ebpf_free_string(error_message);
-        }
+        ebpf_free_string(report);
+        ebpf_free_string(error_message);
     }
 
     // Test disassembly APIs.
@@ -1814,12 +1805,8 @@ TEST_CASE("ebpf_verification_apis", "[ebpf_api]")
         }
 
         // Clean up strings.
-        if (disassembly != nullptr) {
-            ebpf_free_string(disassembly);
-        }
-        if (error_message != nullptr) {
-            ebpf_free_string(error_message);
-        }
+        ebpf_free_string(disassembly);
+        ebpf_free_string(error_message);
     }
 }
 
@@ -2100,9 +2087,7 @@ TEST_CASE("ebpf_enumerate_sections_deprecated", "[ebpf_api]")
     }
 
     // Clean up error message if any.
-    if (error_message != nullptr) {
-        ebpf_free_string(error_message);
-    }
+    ebpf_free_string(error_message);
 }
 
 // Test deprecated ebpf_get_next_pinned_program_path API.
@@ -2144,25 +2129,17 @@ TEST_CASE("ebpf_verification_memory_apis", "[ebpf_api]")
     REQUIRE(result != 0); // Not successful verification.
 
     // Clean up strings.
-    if (report != nullptr) {
-        ebpf_free_string(report);
-    }
-    if (error_message != nullptr) {
-        ebpf_free_string(error_message);
-    }
+    ebpf_free_string(report);
+    ebpf_free_string(error_message);
 
     // Test with null data - should fail gracefully.
     result = ebpf_api_elf_verify_program_from_memory(
         nullptr, 0, nullptr, nullptr, nullptr, EBPF_VERIFICATION_VERBOSITY_NORMAL, &report, &error_message, &stats);
     REQUIRE(result != 0);
 
     // Clean up strings.
-    if (report != nullptr) {
-        ebpf_free_string(report);
-    }
-    if (error_message != nullptr) {
-        ebpf_free_string(error_message);
-    }
+    ebpf_free_string(report);
+    ebpf_free_string(error_message);
 }
 
 // Test remaining deprecated eBPF verification APIs for completeness.
@@ -2183,12 +2160,8 @@ TEST_CASE("ebpf_deprecated_verification_apis", "[ebpf_api]")
     }
 
     // Clean up strings.
-    if (disassembly != nullptr) {
-        ebpf_free_string(disassembly);
-    }
-    if (error_message != nullptr) {
-        ebpf_free_string(error_message);
-    }
+    ebpf_free_string(disassembly);
+    ebpf_free_string(error_message);
 
     // Test deprecated verify section from file API.
     const char* report = nullptr;
@@ -2207,12 +2180,8 @@ TEST_CASE("ebpf_deprecated_verification_apis", "[ebpf_api]")
 #pragma warning(pop)
 
     // Clean up strings.
-    if (report != nullptr) {
-        ebpf_free_string(report);
-    }
-    if (error_message != nullptr) {
-        ebpf_free_string(error_message);
-    }
+    ebpf_free_string(report);
+    ebpf_free_string(error_message);
 
     // Test deprecated verify section from memory API.
     const char* test_data = "minimal_test_data";
@@ -2234,10 +2203,6 @@ TEST_CASE("ebpf_deprecated_verification_apis", "[ebpf_api]")
     REQUIRE(result != 0); // Not successful verification.
 
     // Clean up strings.
-    if (report != nullptr) {
-        ebpf_free_string(report);
-    }
-    if (error_message != nullptr) {
-        ebpf_free_string(error_message);
-    }
+    ebpf_free_string(report);
+    ebpf_free_string(error_message);
 }