Remove BlobPayloadStoreOptions and fix constructor, update agents instructions

Author: andystaples

.github/copilot-instructions.md

@@ -15,13 +15,20 @@ building durable orchestrations. The repo contains two packages:
 - Follow PEP 8 conventions.
 - Use `autopep8` for Python formatting.
 
+## Python Type Checking
+
+Before linting, check for and fix any Pylance errors in the files you
+changed. Use the editor's diagnostics (or the `get_errors` tool) to
+identify type errors and resolve them first — type safety takes
+priority over style.
+
 ## Python Linting
 
 This repository uses [flake8](https://flake8.pycqa.org/) for Python
 linting. Run it after making changes to verify there are no issues:
 
 ```bash
-flake8 path/to/changed/file.py
+python -m flake8 path/to/changed/file.py
 ```
 
 ## Markdown Style
@@ -57,33 +64,33 @@ repository root.
 To lint a single file:
 
 ```bash
-pymarkdown -c .pymarkdown.json scan path/to/file.md
+python -m pymarkdown -c .pymarkdown.json scan path/to/file.md
 ```
 
 To lint all Markdown files in the repository:
 
 ```bash
-pymarkdown -c .pymarkdown.json scan **/*.md
+python -m pymarkdown -c .pymarkdown.json scan **/*.md
 ```
 
 Install the linter via the dev dependencies:
 
 ```bash
-pip install -r dev-requirements.txt
+python -m pip install -r dev-requirements.txt
 ```
 
 ## Building and Testing
 
 Install the packages locally in editable mode:
 
 ```bash
-pip install -e . -e ./durabletask-azuremanaged
+python -m pip install -e . -e ./durabletask-azuremanaged
 ```
 
 Run tests with pytest:
 
 ```bash
-pytest
+python -m pytest
 ```
 
 ## Project Structure

CHANGELOG.md

@@ -15,7 +15,7 @@ ADDED
   Pass a `BlobPayloadStore` to the worker and client via the
   `payload_store` parameter.
 - Added `durabletask.extensions.azure_blob_payloads` extension
-  package with `BlobPayloadStore` and `BlobPayloadStoreOptions`
+  package with `BlobPayloadStore`
 - Added `PayloadStore` abstract base class in
   `durabletask.payload` for custom storage backends
 - Added `durabletask.testing` module with `InMemoryOrchestrationBackend` for testing orchestrations without a sidecar process

docs/features.md

@@ -186,16 +186,15 @@ The built-in `BlobPayloadStore` uses Azure Blob Storage. Create a
 store instance and pass it to both the worker and client:
 
 ```python
-from durabletask.extensions.azure_blob_payloads import BlobPayloadStore, BlobPayloadStoreOptions
+from durabletask.extensions.azure_blob_payloads import BlobPayloadStore
 
-options = BlobPayloadStoreOptions(
+store = BlobPayloadStore(
     connection_string="DefaultEndpointsProtocol=https;...",
     container_name="durabletask-payloads",  # default
     threshold_bytes=900_000,                # default (900 KB)
     max_stored_payload_bytes=10_485_760,    # default (10 MB)
     enable_compression=True,                # default
 )
-store = BlobPayloadStore(options)
 ```
 
 Then pass the store to the worker and client:
@@ -226,11 +225,10 @@ You can also authenticate using `account_url` and a
 ```python
 from azure.identity import DefaultAzureCredential
 
-options = BlobPayloadStoreOptions(
+store = BlobPayloadStore(
     account_url="https://<account>.blob.core.windows.net",
     credential=DefaultAzureCredential(),
 )
-store = BlobPayloadStore(options)
 ```
 
 #### Configuration options

docs/supported-patterns.md

@@ -133,14 +133,14 @@ install the optional dependency and configure a payload store on the
 worker and client:
 
 ```python
-from durabletask.extensions.azure_blob_payloads import BlobPayloadStore, BlobPayloadStoreOptions
+from durabletask.extensions.azure_blob_payloads import BlobPayloadStore
 from durabletask.azuremanaged.client import DurableTaskSchedulerClient
 from durabletask.azuremanaged.worker import DurableTaskSchedulerWorker
 
 # Configure the blob payload store
-store = BlobPayloadStore(BlobPayloadStoreOptions(
+store = BlobPayloadStore(
     connection_string="DefaultEndpointsProtocol=https;...",
-))
+)
 
 # Pass the store to both worker and client
 with DurableTaskSchedulerWorker(

durabletask/extensions/azure_blob_payloads/__init__.py

@@ -13,10 +13,7 @@
 
 Usage::
 
-    from durabletask.extensions.azure_blob_payloads import (
-        BlobPayloadStore,
-        BlobPayloadStoreOptions,
-    )
+    from durabletask.extensions.azure_blob_payloads import BlobPayloadStore
 
     store = BlobPayloadStore(
         connection_string="DefaultEndpointsProtocol=https;...",
@@ -33,6 +30,5 @@
     ) from exc
 
 from durabletask.extensions.azure_blob_payloads.blob_payload_store import BlobPayloadStore
-from durabletask.extensions.azure_blob_payloads.options import BlobPayloadStoreOptions
 
-__all__ = ["BlobPayloadStore", "BlobPayloadStoreOptions"]
+__all__ = ["BlobPayloadStore"]

durabletask/extensions/azure_blob_payloads/blob_payload_store.py

@@ -8,12 +8,11 @@
 import gzip
 import logging
 import uuid
-from typing import Optional
+from typing import Any, Optional
 
 from azure.storage.blob import BlobServiceClient
 from azure.storage.blob.aio import BlobServiceClient as AsyncBlobServiceClient
 
-from durabletask.extensions.azure_blob_payloads.options import BlobPayloadStoreOptions
 from durabletask.payload.store import LargePayloadStorageOptions, PayloadStore
 
 logger = logging.getLogger("durabletask-blobpayloads")
@@ -36,59 +35,66 @@ class BlobPayloadStore(PayloadStore):
         account_url: Azure Storage account URL.  Must be combined with
             *credential*.
         credential: A ``TokenCredential`` for token-based auth.
-        options: Additional configuration.  If not provided, defaults
-            are used.
+        container_name: Blob container for externalized payloads.
+        threshold_bytes: Payloads larger than this are externalized.
+        max_stored_payload_bytes: Maximum externalized payload size.
+        enable_compression: GZip-compress payloads before uploading.
+        api_version: Azure Storage API version override (useful for
+            Azurite compatibility).
     """
 
     def __init__(
         self,
         *,
         connection_string: Optional[str] = None,
         account_url: Optional[str] = None,
-        credential: Optional[object] = None,
-        options: Optional[BlobPayloadStoreOptions] = None,
+        credential: Any = None,
+        container_name: str = "durabletask-payloads",
+        threshold_bytes: int = 900_000,
+        max_stored_payload_bytes: int = 10 * 1024 * 1024,
+        enable_compression: bool = True,
+        api_version: Optional[str] = None,
     ):
-        if options is None:
-            options = BlobPayloadStoreOptions(
-                connection_string=connection_string,
-                account_url=account_url,
-                credential=credential,
-            )
-
-        if not options.connection_string and not options.account_url:
+        if not connection_string and not account_url:
             raise ValueError(
                 "Either 'connection_string' or 'account_url' (with 'credential') must be provided."
             )
 
-        self._options = options
-        self._container_name = options.container_name
+        self._options = LargePayloadStorageOptions(
+            threshold_bytes=threshold_bytes,
+            max_stored_payload_bytes=max_stored_payload_bytes,
+            enable_compression=enable_compression,
+        )
+        self._container_name = container_name
 
         # Optional kwargs shared by both sync and async clients.
         extra_kwargs: dict = {}
-        if options.api_version:
-            extra_kwargs["api_version"] = options.api_version
+        if api_version:
+            extra_kwargs["api_version"] = api_version
 
         # Build sync client
-        if options.connection_string:
+        if connection_string:
             self._blob_service_client = BlobServiceClient.from_connection_string(
-                options.connection_string, **extra_kwargs,
+                connection_string, **extra_kwargs,
             )
         else:
+            assert account_url is not None  # guaranteed by validation above
             self._blob_service_client = BlobServiceClient(
-                account_url=options.account_url,
-                credential=options.credential,
+                account_url=account_url,
+                credential=credential,
                 **extra_kwargs,
             )
 
         # Build async client
-        if options.connection_string:
+        if connection_string:
             self._async_blob_service_client = AsyncBlobServiceClient.from_connection_string(
-                options.connection_string, **extra_kwargs,
+                connection_string, **extra_kwargs,
             )
         else:
+            assert account_url is not None  # guaranteed by validation above
             self._async_blob_service_client = AsyncBlobServiceClient(
-                account_url=options.account_url,
-                credential=options.credential,
+                account_url=account_url,
+                credential=credential,
                 **extra_kwargs,
             )
 

durabletask/extensions/azure_blob_payloads/options.py

@@ -102,7 +102,7 @@ $env:STORAGE_CONNECTION_STRING = "DefaultEndpointsProtocol=https;..."
 
 ## Configuration Options
 
-The `BlobPayloadStoreOptions` class supports the following settings:
+The `BlobPayloadStore` constructor supports the following settings:
 
 | Option | Default | Description |
 |---|---|---|

examples/large_payload/README.md

@@ -14,7 +14,6 @@
 
 Usage (emulator + Azurite — no Azure resources needed):
     # Start the DTS emulator (port 8080) and Azurite (port 10000)
-    export STORAGE_CONNECTION_STRING="DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://127.0.0.1:10000/devstoreaccount1;"
     python app.py
 
 Usage (Azure):
@@ -31,7 +30,7 @@
 from durabletask import client, task
 from durabletask.azuremanaged.client import DurableTaskSchedulerClient
 from durabletask.azuremanaged.worker import DurableTaskSchedulerWorker
-from durabletask.extensions.azure_blob_payloads import BlobPayloadStore, BlobPayloadStoreOptions
+from durabletask.extensions.azure_blob_payloads import BlobPayloadStore
 
 
 # --------------- Activities ---------------
@@ -71,22 +70,18 @@ def main():
     # Azure Storage connection string (defaults to Azurite)
     storage_conn_str = os.getenv(
         "STORAGE_CONNECTION_STRING",
-        "DefaultEndpointsProtocol=http;"
-        "AccountName=devstoreaccount1;"
-        "AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsu"
-        "Fq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;"
-        "BlobEndpoint=http://127.0.0.1:10000/devstoreaccount1;",
+        "UseDevelopmentStorage=true",
     )
 
     print(f"Using taskhub: {taskhub_name}")
     print(f"Using endpoint: {endpoint}")
 
     # Configure the blob payload store
-    store = BlobPayloadStore(BlobPayloadStoreOptions(
+    store = BlobPayloadStore(
         connection_string=storage_conn_str,
         # Use a low threshold so that we can see externalization in action
         threshold_bytes=1_024,
-    ))
+    )
 
     secure_channel = endpoint.startswith("https://")
     credential = DefaultAzureCredential() if secure_channel else None

examples/large_payload/app.py

@@ -409,38 +409,32 @@ def test_is_known_token(self):
 
 
 # ------------------------------------------------------------------
-# Tests: BlobPayloadStoreOptions
+# Tests: BlobPayloadStore construction and defaults
 # ------------------------------------------------------------------
 
 
-class TestBlobPayloadStoreOptions:
+class TestBlobPayloadStoreDefaults:
     def test_default_options(self):
-        """Default options should match .NET SDK defaults."""
+        """Constructing with connection_string should use .NET SDK defaults."""
         pytest.importorskip("azure.storage.blob")
-        from durabletask.extensions.azure_blob_payloads.options import BlobPayloadStoreOptions
+        from durabletask.extensions.azure_blob_payloads.blob_payload_store import BlobPayloadStore
 
-        opts = BlobPayloadStoreOptions()
+        store = BlobPayloadStore(connection_string="UseDevelopmentStorage=true")
+        opts = store.options
         assert opts.threshold_bytes == 900_000
         assert opts.max_stored_payload_bytes == 10 * 1024 * 1024
         assert opts.enable_compression is True
-        assert opts.container_name == "durabletask-payloads"
-        assert opts.connection_string is None
-        assert opts.account_url is None
-        assert opts.credential is None
 
     def test_custom_options(self):
-        """Custom options should be respected."""
+        """Custom constructor params should be reflected in options."""
         pytest.importorskip("azure.storage.blob")
-        from durabletask.extensions.azure_blob_payloads.options import BlobPayloadStoreOptions
+        from durabletask.extensions.azure_blob_payloads.blob_payload_store import BlobPayloadStore
 
-        opts = BlobPayloadStoreOptions(
-            threshold_bytes=500_000,
-            container_name="my-container",
+        store = BlobPayloadStore(
             connection_string="UseDevelopmentStorage=true",
+            threshold_bytes=500_000,
         )
-        assert opts.threshold_bytes == 500_000
-        assert opts.container_name == "my-container"
-        assert opts.connection_string == "UseDevelopmentStorage=true"
+        assert store.options.threshold_bytes == 500_000
 
 
 # ------------------------------------------------------------------