Skip to content

Commit 17658ed

Browse files
authored
Fix Unix deployment of frontend (#194)
### Motivation and Context I introduced a bug with #165 in the frontend deployment script ### Description Use proper Unix commands in the shell script ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
1 parent ec8a7d6 commit 17658ed

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/workflows/copilot-deploy-frontend.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,12 @@ jobs:
8282
- name: Set version tag
8383
id: versiontag
8484
run: |
85-
$VERSION_TAG = "${{ steps.gitversion.outputs.Major }}."
86-
$VERSION_TAG += "${{ steps.gitversion.outputs.Minor }}."
87-
$VERSION_TAG += "${{ steps.gitversion.outputs.CommitsSinceVersionSource }}"
85+
VERSION_TAG="${{ steps.gitversion.outputs.Major }}."
86+
VERSION_TAG+="${{ steps.gitversion.outputs.Minor }}."
87+
VERSION_TAG+="${{ steps.gitversion.outputs.CommitsSinceVersionSource }}"
8888
echo $VERSION_TAG
89-
Write-Output "versiontag=$VERSION_TAG" >> $env:GITHUB_OUTPUT
89+
echo "versiontag=$VERSION_TAG" >> "$GITHUB_OUTPUT"
9090
9191
- name: Deploy SWA
9292
run: |
93-
scripts/deploy/deploy-webapp.sh --subscription ${{secrets.AZURE_SUBSCRIPTION_ID}} --resource-group ${{vars.CC_DEPLOYMENT_GROUP_NAME}} --deployment-name ${{inputs.DEPLOYMENT_NAME}} --application-id ${{vars.APPLICATION_CLIENT_ID}} --authority ${{secrets.APPLICATION_AUTHORITY}} --no-redirect -version ${{ steps.versiontag.outputs.versiontag }} -version-info "Built from commit ${{ steps.gitversion.outputs.ShortSha }} on $(Get-Date -Format "yyyy-MM-dd")"
93+
scripts/deploy/deploy-webapp.sh --subscription ${{secrets.AZURE_SUBSCRIPTION_ID}} --resource-group ${{vars.CC_DEPLOYMENT_GROUP_NAME}} --deployment-name ${{inputs.DEPLOYMENT_NAME}} --application-id ${{vars.APPLICATION_CLIENT_ID}} --authority ${{secrets.APPLICATION_AUTHORITY}} --no-redirect --version ${{ steps.versiontag.outputs.versiontag }} --version-info "Built from commit ${{ steps.gitversion.outputs.ShortSha }} on $(date +"%Y-%m-%d")"

scripts/deploy/deploy-webapp.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ while [[ $# -gt 0 ]]; do
5454
shift
5555
shift
5656
;;
57-
-i|--version-nfo)
57+
-i|--version-info)
5858
VERSION_INFO="$2"
5959
shift
6060
shift
@@ -177,4 +177,4 @@ if [ "$NO_REDIRECT" != true ]; then
177177
fi
178178
fi
179179

180-
echo "To verify your deployment, go to 'https://$WEB_APP_URL' in your browser."
180+
echo "To verify your deployment, go to 'https://$WEB_APP_URL' in your browser."

0 commit comments

Comments
 (0)