Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated transcript tests #4522

Open
ceciliaavila opened this issue Aug 18, 2023 · 0 comments
Open

Outdated transcript tests #4522

ceciliaavila opened this issue Aug 18, 2023 · 0 comments
Assignees
@ceciliaavila
Labels
bug Indicates an unexpected problem or an unintended behavior. P2 Nice to have

Comments

@ceciliaavila
Copy link
Collaborator

Versions

4.20.0

Describe the bug

While working on removing the request package from botbuilder-js, we found these transcript tests for different botbuilder components (dialogs, middleware, and ai).

These tests were disabled in this commit. They are outdated. They use broken references and have errors in the code that make them fail.

As the .NET counterpart has these tests enabled, we should fix the errors to have them working again.

Expected behavior

The tests should be able to run successfully.
@ceciliaavila ceciliaavila added the bug Indicates an unexpected problem or an unintended behavior. label Aug 18, 2023
@ceciliaavila ceciliaavila self-assigned this Aug 18, 2023
@ceciliaavila ceciliaavila added the P2 Nice to have label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
bug Indicates an unexpected problem or an unintended behavior. P2 Nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ceciliaavila