Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [botframework-streaming] Some named pipe tests are not passing after fixing their inconclusiveness #4494

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: [botframework-streaming] Some named pipe tests are not passing after fixing their inconclusiveness #4494

wants to merge 3 commits into from

Conversation

erquirogasw
Copy link
Contributor

Fixes #4462

Description

This PR fixes the NamedPipe unit tests that weren't passing.
It adds code to the receive method of the NamedPipeTransport class to handle null and destroyed sockets.
Additionally, it updates the transport unit test to be compatible with the new changes and the client-server tests to make the connection correctly.

Specific Changes

  • New condition in the receive method of the NamedPipeTransport class to handle null and destroyed sockets.
  • Updated 'throws then reading from a dead socket' unit test to be compatible with the changes of the receive method.
  • Updated client and server 'sends without throwing' unit tests to make the connection correctly.

Testing

image

@erquirogasw
fix tests
a37c271 
updated NamedPipeTransport class to handle null and destroyed sockets

updated NamedPipe tests
@erquirogasw
suggested changes applied
4e09988
@erquirogasw
Add suggested changes
1e624bf
@erquirogasw erquirogasw requested a review from a team as a code owner June 21, 2023 13:50
@coveralls
Copy link

coveralls commented Jun 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5334935081

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 84.484%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/namedPipe/namedPipeTransport.ts 1 96.36%
Totals Coverage Status
Change from base Build 5222839148: -0.02%
Covered Lines: 20037
Relevant Lines: 22480
💛 - Coveralls

@tracyboehrer
Copy link
Member

These tests are failing due to missing Azure resources. Solution pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[botframework-streaming] Some named pipe tests are not passing after fixing their inconclusiveness
3 participants
@erquirogasw @coveralls @tracyboehrer