Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node] Crash on websocket errors #4431

Open
orgads opened this issue Feb 12, 2023 · 3 comments
Open

[node] Crash on websocket errors #4431

orgads opened this issue Feb 12, 2023 · 3 comments
Assignees
@compulim
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@orgads
Copy link

orgads commented Feb 12, 2023

Versions

What package version of the SDK are you using.
4.19.1-rc
What nodejs version are you using
18.14.0
What os are you using
Windows

Describe the bug

Give a clear and concise description of what the bug is.
With the recent fixes to the streaming framework, I can start the connection, but if I get an error, an unhandled exception is thrown from here, and I can't find a way to handle it. Looks similar to microsoft/BotFramework-DirectLineJS#170.

To Reproduce

Connect to a URL that doesn't respond.

Expected behavior

It should propagate the error to be handled by the client code.
@orgads orgads added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Feb 12, 2023
@orgads
Copy link
Author

orgads commented Feb 12, 2023

Reported originally here: #4412 (comment)

@breakingram breakingram added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Feb 13, 2023
@axelsrz
Copy link
Member

axelsrz commented Feb 14, 2023

@compulim do we have any updates on this?

@tracyboehrer tracyboehrer added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Mar 7, 2023
@tracyboehrer
Copy link
Member

@compulim Is this still a thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tracyboehrer @orgads @compulim @axelsrz @breakingram