Suppressed general exception warning (#6851)

tracyboehrer · Tracy Boehrer · Tracy Boehrer · commit a1f20f070018 · 2024-09-19T11:51:47.000-05:00
Co-authored-by: Tracy Boehrer &lt;trboehre@microsoft.com&gt;
diff --git a/libraries/Microsoft.Bot.Builder.Dialogs/SkillDialog.cs b/libraries/Microsoft.Bot.Builder.Dialogs/SkillDialog.cs
@@ -338,6 +338,7 @@ private async Task<bool> InterceptOAuthCardsAsync(ITurnContext turnContext, Acti
                 return false;
             }
 
+#pragma warning disable CA1031 // Do not catch general exception types
             try
             {
                 var settings = new OAuthPromptSettings() { ConnectionName = connectionName };
@@ -357,6 +358,7 @@ private async Task<bool> InterceptOAuthCardsAsync(ITurnContext turnContext, Acti
                 // Failures in token exchange are not fatal. They simply mean that the user needs to be shown the OAuth card.
                 return false;
             }
+#pragma warning restore CA1031 // Do not catch general exception types
         }
 
         private async Task<bool> SendTokenExchangeInvokeToSkillAsync(Activity incomingActivity, string id, string connectionName, string token, CancellationToken cancellationToken)

Original file line number	Diff line number	Diff line change
`@@ -338,6 +338,7 @@ private async Task<bool> InterceptOAuthCardsAsync(ITurnContext turnContext, Acti`
`338`	`338`	`return false;`
`339`	`339`	`}`
`340`	`340`
	`341`	`+#pragma warning disable CA1031 // Do not catch general exception types`
`341`	`342`	`try`
`342`	`343`	`{`
`343`	`344`	`var settings = new OAuthPromptSettings() { ConnectionName = connectionName };`
`@@ -357,6 +358,7 @@ private async Task<bool> InterceptOAuthCardsAsync(ITurnContext turnContext, Acti`
`357`	`358`	`// Failures in token exchange are not fatal. They simply mean that the user needs to be shown the OAuth card.`
`358`	`359`	`return false;`
`359`	`360`	`}`
	`361`	`+#pragma warning restore CA1031 // Do not catch general exception types`
`360`	`362`	`}`
`361`	`363`
`362`	`364`	`private async Task<bool> SendTokenExchangeInvokeToSkillAsync(Activity incomingActivity, string id, string connectionName, string token, CancellationToken cancellationToken)`