Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options should merge recursively #1007

Open
ecraig12345 opened this issue Nov 18, 2024 · 0 comments
Open

Options should merge recursively #1007

ecraig12345 opened this issue Nov 18, 2024 · 0 comments

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Nov 18, 2024

getOptions and getCombinedPackageOptions should be recursively merging object properties instead of overwriting them (arrays should still be overwritten).

Code from a previous attempt before realizing the issue applied to getOptions too: https://github.com/microsoft/beachball/tree/ecraig/object-merge

I'm marking this as a breaking change because it's entirely possible that some repos have configs that either expect or manually work around the non-recursive merging behavior, so it's safest to only change this with an explicit call-out in a major release.

@ecraig12345 ecraig12345 changed the title Package options should merge recursively Options should merge recursively Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant