Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key endpoints returns 400 when there aren't any keys #167

Open
Tracked by #166
DomAyre opened this issue Oct 17, 2024 · 1 comment
Open
Tracked by #166

Key endpoints returns 400 when there aren't any keys #167

DomAyre opened this issue Oct 17, 2024 · 1 comment

Comments

@DomAyre
Copy link
Collaborator

DomAyre commented Oct 17, 2024

This applies to a couple of endpoints /listpubkeys, /key and pubkey, for /listpubkeys not sure if this is intended behaviour or not, but I would assume we should return 200 with the same schema as when there are keys, with an empty list of keys, but instead we get nothing and a return of 400

@DomAyre DomAyre changed the title /listpubkeys returns 400 when there aren't any keys /listpubkeys returns 400 when there aren't any keys Oct 17, 2024
@DomAyre
Copy link
Collaborator Author

DomAyre commented Oct 23, 2024

Looking at the implementation it looks like this is deliberate, but I'm going to keep the issue open because I wonder if it would be better to return 200 with an empty list or a 404

@DomAyre DomAyre changed the title /listpubkeys returns 400 when there aren't any keys Key endpoints returns 400 when there aren't any keys Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant