Skip to content

Commit 627aa16

Browse files
authored
Update the check of the msdeploy version (#359)
1 parent 83a8fe1 commit 627aa16

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

common-npm-packages/webdeployment-common/msdeployutility.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -286,14 +286,21 @@ export async function getInstalledMSDeployVersion(): Promise<string> {
286286
}
287287

288288
export async function installedMSDeployVersionSupportsTokenAuth(): Promise<boolean | undefined> {
289-
// MSDeploy 9.0.7225 is the first product version to support token auth
290-
const minimalMSDeployVersion = "9.0.7225";
291-
const msDeployVersion = await getInstalledMSDeployVersion();
292-
if (!msDeployVersion) {
289+
const msDeployVersionString = await getInstalledMSDeployVersion();
290+
if (!msDeployVersionString) {
293291
tl.debug('Could not determine MSDeploy version. Assuming it is not installed.');
294292
return undefined;
295293
}
296-
return semver.gte(semver.coerce(msDeployVersion), semver.coerce(minimalMSDeployVersion));
294+
295+
const msDeployVersion = semver.coerce(msDeployVersionString);
296+
// MSDeploy 9.0.7225 is the first product version to support token auth
297+
if (semver.gte(msDeployVersion, semver.coerce("9.0.7225"))) {
298+
return true;
299+
}
300+
301+
// MDeploy shipped with Web Deploy has different versioning scheme
302+
// Versions between 9.0.2000 and 9.0.2999 are considered to be similar to 9.0.7225
303+
return semver.gte(msDeployVersion, semver.coerce("9.0.2000")) && semver.lte(msDeployVersion, semver.coerce("9.0.2999"));
297304
}
298305

299306
function getMSDeployLatestRegKey(): Promise<winreg.Registry> {

common-npm-packages/webdeployment-common/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common-npm-packages/webdeployment-common/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "azure-pipelines-tasks-webdeployment-common",
3-
"version": "4.243.0",
3+
"version": "4.243.1",
44
"description": "Common Lib for MSDeploy Utility",
55
"repository": {
66
"type": "git",

0 commit comments

Comments
 (0)