Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on Q in favor of native Promises #900

Open
JamieMagee opened this issue Nov 29, 2022 · 13 comments
Open

Remove dependency on Q in favor of native Promises #900

JamieMagee opened this issue Nov 29, 2022 · 13 comments
Labels
Area: TaskLib dependencies Pull requests that update a dependency file enhancement no-stale

Comments

@JamieMagee
Copy link
Member

Environment

azure-pipelines-task-lib version: 3.4.0

Issue Description

azure-pipelines-task-lib currently has a hard dependency on q, a Promise library for JavaScript. This was necessary in the early days of JavaScript, but since ES6/ES2015 the JavaScript standard has had native support for Promises. q hasn't published a new release in over 5 years, and has a note on the GitHub repo

Please consider using JavaScript promises instead of Q. Native promises are faster, have better tooling support and are the future.

Support for native Promises in Node has been available since Node v4.

Expected behaviour

No dependency on q

Actual behaviour

A dependency on q
@max-zaytsev max-zaytsev added dependencies Pull requests that update a dependency file enhancement and removed triage labels Nov 30, 2022
@max-zaytsev
Copy link
Contributor

Hi @JamieMagee, thanks for reporting this.
We are currently working on higher priority issues. But we'll get back to that soon.

@github-actions
Copy link

This issue has had no activity in 90 days. Please comment if it is not actually stale

@github-actions github-actions bot added the stale label Feb 28, 2023
@github-actions github-actions bot closed this as completed Mar 7, 2023
@JamieMagee
Copy link
Member Author

This issue isn't stale

@LiliaSabitova LiliaSabitova reopened this Mar 9, 2023
@Everspace
Copy link

This would be great, Jamie has also kindly opened a pull request for this too! #905

@jessehouwing
Copy link
Contributor

@github-actions
Copy link

This issue has had no activity in 90 days. Please comment if it is not actually stale

@github-actions github-actions bot added the stale label Jun 20, 2023
@Everspace
Copy link

Still would be nice

@github-actions github-actions bot removed the stale label Jun 20, 2023
@github-actions
Copy link

This issue has had no activity in 90 days. Please comment if it is not actually stale

@github-actions github-actions bot added the stale label Sep 18, 2023
@Everspace
Copy link

This is not totally complete. As of the pull of #905 "This only handles the node directory. There are still uses of Q under the powershell directory.", so this issue is not resolved.

@github-actions github-actions bot removed the stale label Sep 18, 2023
@github-actions GitHub Actions
Copy link

This issue has had no activity in 90 days. Please comment if it is not actually stale

@github-actions github-actions bot added the stale label Dec 17, 2023
@jessehouwing
Copy link
Contributor

Not stale

@github-actions github-actions bot removed the stale label Dec 17, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

This issue has had no activity in 90 days. Please comment if it is not actually stale

@github-actions github-actions bot added the stale label Apr 7, 2024
@JamieMagee
Copy link
Member Author

This isn't completed. Please re-open the issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: TaskLib dependencies Pull requests that update a dependency file enhancement no-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@JamieMagee @jessehouwing @Everspace @max-zaytsev @KonstantinTyukalov @LiliaSabitova and others