Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audio/sysvad] APO_BUFFER_FLAGS not used as flags in sample #1160

Open
kurylo opened this issue Apr 17, 2024 · 0 comments
Open

[audio/sysvad] APO_BUFFER_FLAGS not used as flags in sample #1160

kurylo opened this issue Apr 17, 2024 · 0 comments
Assignees
Labels

Comments

@kurylo
Copy link

kurylo commented Apr 17, 2024

Is the APO_BUFFER_FLAGS handling implemented in the SwapAPO using switch statement correct?

Name flags suggests that multiple flags can be set at once e.g.: both BUFFER_VALID and BUFFER_SILENT with a resulting value of 0x3. This would require a different handling than a switch statement.

Clarification in the document:
https://learn.microsoft.com/en-us/windows/win32/api/audioapotypes/ne-audioapotypes-apo_buffer_flags
is needed on whether the ppInputConnections[0]->u32BufferFlags are to be treated as flags (as the field name suggests) or as an enumeration with only one value valid at a time. The current wording in the document using both enumeration and flags is ambiguous.

@NeoAdonis NeoAdonis assigned NeoAdonis and judzmura and unassigned NeoAdonis Apr 24, 2024
@NeoAdonis NeoAdonis changed the title APO_BUFFER_FLAGS not used as flags in sample [audio/sysvad] APO_BUFFER_FLAGS not used as flags in sample Apr 24, 2024
@NeoAdonis NeoAdonis added the bug label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants