From f80f0bf7fc9d7fc2ae8b77b6dab648c1e0b366c0 Mon Sep 17 00:00:00 2001 From: Ryan Cavanaugh Date: Tue, 5 Nov 2024 15:13:41 -0800 Subject: [PATCH 1/2] Ignore skipLibCheck (experiment) We're just curious what breaks --- src/compiler/utilities.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts index d12ae297b81ad..fdfe216f6e601 100644 --- a/src/compiler/utilities.ts +++ b/src/compiler/utilities.ts @@ -10295,7 +10295,7 @@ function skipTypeCheckingWorker( // If skipLibCheck is enabled, skip reporting errors if file is a declaration file. // If skipDefaultLibCheck is enabled, skip reporting errors if file contains a // '/// ' directive. - return (options.skipLibCheck && sourceFile.isDeclarationFile || + return (sourceFile.isDeclarationFile || options.skipDefaultLibCheck && sourceFile.hasNoDefaultLib) || (!ignoreNoCheck && options.noCheck) || host.isSourceOfProjectReferenceRedirect(sourceFile.fileName) || From d319e604e78e7632235757850c3f7bff54be64a4 Mon Sep 17 00:00:00 2001 From: Ryan Cavanaugh Date: Wed, 6 Nov 2024 08:56:48 -0800 Subject: [PATCH 2/2] Oops --- src/compiler/utilities.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts index fdfe216f6e601..d0aa4595d01a7 100644 --- a/src/compiler/utilities.ts +++ b/src/compiler/utilities.ts @@ -10292,14 +10292,7 @@ function skipTypeCheckingWorker( host: HostWithIsSourceOfProjectReferenceRedirect, ignoreNoCheck: boolean, ) { - // If skipLibCheck is enabled, skip reporting errors if file is a declaration file. - // If skipDefaultLibCheck is enabled, skip reporting errors if file contains a - // '/// ' directive. - return (sourceFile.isDeclarationFile || - options.skipDefaultLibCheck && sourceFile.hasNoDefaultLib) || - (!ignoreNoCheck && options.noCheck) || - host.isSourceOfProjectReferenceRedirect(sourceFile.fileName) || - !canIncludeBindAndCheckDiagnostics(sourceFile, options); + return false; } /** @internal */