Skip to content

Commit 89fd4f0

Browse files
committed
test(compiler): remove stray baselines and add correct uniqueSymbolReassignment outputs
1 parent 5db0560 commit 89fd4f0

File tree

7 files changed

+103
-236
lines changed

7 files changed

+103
-236
lines changed

tests/baselines/reference/uniqueSymbolReassignment.d.symbols

Lines changed: 0 additions & 38 deletions
This file was deleted.

tests/baselines/reference/uniqueSymbolReassignment.d.types

Lines changed: 0 additions & 51 deletions
This file was deleted.

tests/baselines/reference/uniqueSymbolReassignment.errors.txt

Lines changed: 0 additions & 48 deletions
This file was deleted.

tests/baselines/reference/uniqueSymbolReassignment.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ myFunction.mySymbol = Symbols.mySymbol;
1919
myFunction.anotherUnique = Symbols2.anotherUnique;
2020

2121
// Non-unique symbols (regular Symbol() without const)
22-
const nonUniqueSymbol1 = Symbol('nonUnique1');
23-
const nonUniqueSymbol2 = Symbol('nonUnique2');
22+
let nonUniqueSymbol1 = Symbol('nonUnique1');
23+
let nonUniqueSymbol2 = Symbol('nonUnique2');
2424

2525
// Plain text variables (not symbols at all)
2626
const normalVar = "not a symbol";
@@ -32,8 +32,7 @@ myFunction.nonUnique2 = nonUniqueSymbol2;
3232
myFunction.normalVar = normalVar;
3333
myFunction.symbolName = symbolName;
3434

35-
export { myFunction };
36-
35+
export { myFunction };
3736

3837
//// [uniqueSymbolReassignment.js]
3938
"use strict";
@@ -68,10 +67,10 @@ myFunction.symbolName = symbolName;
6867
//// [uniqueSymbolReassignment.d.ts]
6968
declare function myFunction(): void;
7069
declare namespace myFunction {
71-
var mySymbol: any;
72-
var anotherUnique: any;
73-
var nonUnique1: any;
74-
var nonUnique2: any;
70+
const mySymbol: unique symbol;
71+
const anotherUnique: unique symbol;
72+
var nonUnique1: symbol;
73+
var nonUnique2: symbol;
7574
var normalVar: string;
7675
var symbolName: string;
7776
}

tests/baselines/reference/uniqueSymbolReassignment.symbols

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
// This is a unique symbol (const + Symbol())
55
const mySymbol = Symbol('Symbols.mySymbol');
66
>mySymbol : Symbol(mySymbol, Decl(uniqueSymbolReassignment.ts, 1, 5))
7+
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2019.symbol.d.ts, --, --))
78

89
const Symbols = {
910
>Symbols : Symbol(Symbols, Decl(uniqueSymbolReassignment.ts, 2, 5))
@@ -16,6 +17,7 @@ const Symbols = {
1617

1718
const anotherUnique = Symbol('symbols.anotherUnique');
1819
>anotherUnique : Symbol(anotherUnique, Decl(uniqueSymbolReassignment.ts, 6, 5))
20+
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2019.symbol.d.ts, --, --))
1921

2022
const Symbols2 = {
2123
>Symbols2 : Symbol(Symbols2, Decl(uniqueSymbolReassignment.ts, 7, 5))
@@ -47,11 +49,13 @@ myFunction.anotherUnique = Symbols2.anotherUnique;
4749
>anotherUnique : Symbol(anotherUnique, Decl(uniqueSymbolReassignment.ts, 7, 18))
4850

4951
// Non-unique symbols (regular Symbol() without const)
50-
const nonUniqueSymbol1 = Symbol('nonUnique1');
51-
>nonUniqueSymbol1 : Symbol(nonUniqueSymbol1, Decl(uniqueSymbolReassignment.ts, 18, 5))
52+
let nonUniqueSymbol1 = Symbol('nonUnique1');
53+
>nonUniqueSymbol1 : Symbol(nonUniqueSymbol1, Decl(uniqueSymbolReassignment.ts, 18, 3))
54+
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2019.symbol.d.ts, --, --))
5255

53-
const nonUniqueSymbol2 = Symbol('nonUnique2');
54-
>nonUniqueSymbol2 : Symbol(nonUniqueSymbol2, Decl(uniqueSymbolReassignment.ts, 19, 5))
56+
let nonUniqueSymbol2 = Symbol('nonUnique2');
57+
>nonUniqueSymbol2 : Symbol(nonUniqueSymbol2, Decl(uniqueSymbolReassignment.ts, 19, 3))
58+
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2019.symbol.d.ts, --, --))
5559

5660
// Plain text variables (not symbols at all)
5761
const normalVar = "not a symbol";
@@ -65,13 +69,13 @@ myFunction.nonUnique1 = nonUniqueSymbol1;
6569
>myFunction.nonUnique1 : Symbol(myFunction.nonUnique1, Decl(uniqueSymbolReassignment.ts, 23, 57))
6670
>myFunction : Symbol(myFunction, Decl(uniqueSymbolReassignment.ts, 9, 11), Decl(uniqueSymbolReassignment.ts, 11, 24), Decl(uniqueSymbolReassignment.ts, 14, 39), Decl(uniqueSymbolReassignment.ts, 23, 57), Decl(uniqueSymbolReassignment.ts, 26, 41) ... and 2 more)
6771
>nonUnique1 : Symbol(myFunction.nonUnique1, Decl(uniqueSymbolReassignment.ts, 23, 57))
68-
>nonUniqueSymbol1 : Symbol(nonUniqueSymbol1, Decl(uniqueSymbolReassignment.ts, 18, 5))
72+
>nonUniqueSymbol1 : Symbol(nonUniqueSymbol1, Decl(uniqueSymbolReassignment.ts, 18, 3))
6973

7074
myFunction.nonUnique2 = nonUniqueSymbol2;
7175
>myFunction.nonUnique2 : Symbol(myFunction.nonUnique2, Decl(uniqueSymbolReassignment.ts, 26, 41))
7276
>myFunction : Symbol(myFunction, Decl(uniqueSymbolReassignment.ts, 9, 11), Decl(uniqueSymbolReassignment.ts, 11, 24), Decl(uniqueSymbolReassignment.ts, 14, 39), Decl(uniqueSymbolReassignment.ts, 23, 57), Decl(uniqueSymbolReassignment.ts, 26, 41) ... and 2 more)
7377
>nonUnique2 : Symbol(myFunction.nonUnique2, Decl(uniqueSymbolReassignment.ts, 26, 41))
74-
>nonUniqueSymbol2 : Symbol(nonUniqueSymbol2, Decl(uniqueSymbolReassignment.ts, 19, 5))
78+
>nonUniqueSymbol2 : Symbol(nonUniqueSymbol2, Decl(uniqueSymbolReassignment.ts, 19, 3))
7579

7680
myFunction.normalVar = normalVar;
7781
>myFunction.normalVar : Symbol(myFunction.normalVar, Decl(uniqueSymbolReassignment.ts, 27, 41))

0 commit comments

Comments
 (0)