Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Big-endian support #17

Open
ningvin opened this issue May 29, 2020 · 0 comments
Open

Question: Big-endian support #17

ningvin opened this issue May 29, 2020 · 0 comments

Comments

@ningvin
Copy link

ningvin commented May 29, 2020

In Metadata.h#L68 the most significant byte of the uint32_t metadatum is accessed by interpreting it as an array of uint8_t and indexing it at the fixed index 3.

As the comment in line 75 of the same file points out, this obviously will only work on little endian machines. I am assuming that this means L4 will not work on big endian machines (e.g. IBM's AIX).

Is this the only issue preventing big endian support or are there other parts (e.g. MurmurHash3.cpp) that would also need to be adapted to support big endian?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant