Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HelloVADecode , HelloVAEncode, and HelloVAResourceInterop fail to build with included solution file #817

Open
kevinf28 opened this issue Mar 21, 2023 · 3 comments · May be fixed by #880
Open

HelloVADecode , HelloVAEncode, and HelloVAResourceInterop fail to build with included solution file #817

kevinf28 opened this issue Mar 21, 2023 · 3 comments · May be fixed by #880
Labels
bug samples Issues related to Samples

Comments

@kevinf28
Copy link

D3D12HelloWorld.sln included with the package appears to be missing the lib folder from Microsoft.Direct3D.VideoAccelerationCompatibilityPack.1.0.0 which contains the va.lib and va_win32.lib
error: "LNK2001 unresolved external symbol vaDestroyConfig"

VideoAccelerationCompatibilityPack NuGet package was already installed for the 3 projects.
Simply adding "va.lib;va_win32.lib" to linker "Additional Dependencies" in each of the projects worked.

Not sure if that is the recommended way your team is handling linker flags, otherwise I would create a PR.

Test Setup:

  • VS 2022 Community Edition + Windows 11 "Next" SDK + target v143

Introduced from #810 @sivileri
@sivileri
Copy link
Contributor

Hi! Thanks for pointing this out. Which architecture/flavor are you building? (ie. Debug/Release/x86/x64)
Did VS automatically restored the nuget packages on the first build? Usually that added the necessary project config, but I'd like to repro with the flavor/arch you had the issue with to make sure that case is being covered.

@kevinf28
Copy link
Author

kevinf28 commented Mar 22, 2023 •
edited
Loading

I was building Release (X64). I haven't dealt with NuGet project configuration before, I'll give the look around the options from your linked page to see if there was something I overlooked there.

Maybe flushing the cache and re-installing the NuGet will help since this was a new install of VS 2022 + "next" SDK over top of VS 2017 + W11 SV2 SDK I had installed previously.

All the other samples compile, since they don't depend on NuGet.

@kevinf28
Copy link
Author

kevinf28 commented Mar 24, 2023 •
edited
Loading

I removed the NuGet packages and get the expected error:
"Error C1083 Cannot open include file: 'va/va.h': No such file or directory "

Re-installing the Nuget to corrects include error, but the linking failure persists. That suggests it is adding the paths correctly but not the linker flags* maybe that is by design. Up to you which libraries to include.

@walbourn walbourn added bug samples Issues related to Samples labels Mar 6, 2024
@TylerNowicki TylerNowicki linked a pull request Aug 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug samples Issues related to Samples
Projects
None yet
Milestone
No milestone
3 participants
@kevinf28 @walbourn @sivileri