Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-leaflet-markercluster from expectedNpmVersionFailures.txt #1097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhubert
Copy link

@bhubert bhubert commented Nov 4, 2024

No description provided.

@bhubert
Copy link
Author

bhubert commented Nov 4, 2024

i removed the entry because i have a ongoing PR to fix the .d.ts DefinitelyTyped/DefinitelyTyped#71086

And this PR fail because of the entry in this repository

react-leaflet-markercluster can be removed from expectedNpmVersionFailures.txt in https://github.com/microsoft/DefinitelyTyped-tools/blob/main/packages/dtslint. at combineErrorsAndWarnings (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/src/index.ts:259:26) at runTests (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/src/index.ts:250:18) at process.processTicksAndRejections (node:internal/process/task_queues:[95](https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/11674046880/job/32506000736?pr=71086#step:11:96):5)  ELIFECYCLE  Command failed with exit code 1.

@charlieforward9
Copy link

Whats preventing us from seeing this merged?

@jakebailey
Copy link
Member

DefinitelyTyped/DefinitelyTyped#71086 needs to go first. This PR does not block that PR, that PR has a different error that needs to be fixed.

@charlieforward9
Copy link

I ended up adding the types to the source repo, so this repo's references can be removed altogether from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants