You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dtslint-runner fetches master, but gets a newer master than the PR, so it believes that the PR modified matter-js, when it was actually another PR merged to master. I partially fixed this for pnpm install in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/scripts/pnpm-install.sh; since PRs are run on merge commits in CI, HEAD^1 points to an already pulled / stable merge base (what the PR thinks master is at the time of the CI run; further runs will get newer merge bases so it's not out of date).
This then causes further failures because pnpm install is installing the "correct" dependency set, which does not include matter-js.
In CI, it's easy to tell that we're in a PR. But, I'm not totally sure of the right mechanism to check in dtslint-runner, but we should definitely do it.
The text was updated successfully, but these errors were encountered:
dtslint-runner diffs against
master
. If someone merges a PR at the exact same time as another PR's CI runs, they'll pullorigin/master
and may get the wrong thing. For example, in https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/7452339628/job/20275379960?pr=68135:dtslint-runner
fetches master, but gets a newer master than the PR, so it believes that the PR modifiedmatter-js
, when it was actually another PR merged to master. I partially fixed this forpnpm install
in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/scripts/pnpm-install.sh; since PRs are run on merge commits in CI,HEAD^1
points to an already pulled / stable merge base (what the PR thinksmaster
is at the time of the CI run; further runs will get newer merge bases so it's not out of date).This then causes further failures because
pnpm install
is installing the "correct" dependency set, which does not includematter-js
.In CI, it's easy to tell that we're in a PR. But, I'm not totally sure of the right mechanism to check in
dtslint-runner
, but we should definitely do it.The text was updated successfully, but these errors were encountered: