Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous identity version contains redundant entries #6559

Open
maxtropets opened this issue Oct 10, 2024 · 0 comments
Open

Previous identity version contains redundant entries #6559

maxtropets opened this issue Oct 10, 2024 · 0 comments

Comments

@maxtropets
Copy link
Collaborator

It seems like previous_service_identity_version was created to maintain a chain between service identities changes caused by DR, at least it follows from the name.

However, it contains redundant entries, which point to the same service identity. At first glance it's unclear why, because it's only supposed to happen on open_service. This needs to be investigated.

The only things which relies on this table is populate_service_endorsements, which still works but makes unnecessary key verification attempts with the same key, when jumping through the same key entries.

However, the field is also exposed at a part of service table, so may be read by users.

@maxtropets maxtropets added the bug label Oct 10, 2024
@achamayou achamayou removed the bug label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants