Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to be more OO #267

Open
FBoucher opened this issue Mar 5, 2021 · 2 comments
Open

Move code to be more OO #267

FBoucher opened this issue Mar 5, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Serverless-Backend Serverless Backend

Comments

@FBoucher
Copy link
Collaborator

FBoucher commented Mar 5, 2021

In UrlShortener.cs around line 109 the cleaning should be inside the object ShortUrlEntity

            string longUrl = input.Url.Trim();
            string vanity = string.IsNullOrWhiteSpace(input.Vanity) ? "" : input.Vanity.Trim();
            string title = string.IsNullOrWhiteSpace(input.Title) ? "" : input.Title.Trim();

┆Issue is synchronized with this Trello card by Unito

@FBoucher FBoucher added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Serverless-Backend Serverless Backend labels Mar 5, 2021
@sync-by-unito sync-by-unito bot closed this as completed Dec 10, 2022
Repository owner moved this from Todo to Done in AzUrlShortener project Dec 10, 2022
@FBoucher FBoucher reopened this Dec 10, 2022
@ananta
Copy link

ananta commented Nov 5, 2023

@FBoucher,

I think this one needs some love. Can I work on this one :) ?!

@Ishpreet01
Copy link

Hi, Can you assign this issue to me? I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Serverless-Backend Serverless Backend
Projects
None yet
Development

No branches or pull requests

3 participants