Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc update for when you add a custom domain #188

Closed
FBoucher opened this issue Oct 5, 2020 · 1 comment
Closed

Doc update for when you add a custom domain #188

FBoucher opened this issue Oct 5, 2020 · 1 comment
Assignees
@FBoucher
Labels
claimed documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest-accepted This PR is lovely and accepted for Hacktoberfest help wanted Extra attention is needed high priority

Comments

@FBoucher
Copy link
Collaborator

FBoucher commented Oct 5, 2020

What an amazing project ❤
Although in its early stages, it works very well and I love the serverless nature of it.

Maybe you should also mention that to add a custom domain you not only need to add it as an app service domain but also change the AzFunctionUrl in the app settings of the admin/web interface so that the copy button uses your custom domain.

Originally posted by @lukaslangrock in #122 (comment)
@FBoucher FBoucher added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest-accepted This PR is lovely and accepted for Hacktoberfest labels Oct 5, 2020
@FBoucher FBoucher self-assigned this Nov 5, 2020
@FBoucher FBoucher mentioned this issue Nov 14, 2020
Merged
@FBoucher
Copy link
Collaborator Author

I will close this the doc is now updated.
bitmoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FBoucher FBoucher

Labels
claimed documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest-accepted This PR is lovely and accepted for Hacktoberfest help wanted Extra attention is needed high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FBoucher