[Event Requet] Table 18 "Customer".GetCustNoOpenCard

[fridrichovsky]

Why do you need this change?

We need extend condition by Customer.Count, similar condition is in standard bellow this part of code.

if Customer.FindFirst() then
   if Customer.Count() = 1 then
       exit(Customer."No.");

Describe the request

procedure GetCustNoOpenCard(CustomerText: Text; ShowCustomerCard: Boolean; ShowCreateCustomerOption: Boolean): Code[20]
   var
       Customer: Record Customer;
       IsHandled: Boolean;
       NoFiltersApplied: Boolean;
       CustomerNo: Code[20];
       CustomerFilterContains: Text;
       CustomerFilterFromStart: Text;
       CustomerWithoutQuote: Text;
   begin
       IsHandled := false;
       OnBeforeGetCustNoOpenCard(CustomerText, ShowCustomerCard, ShowCreateCustomerOption, CustomerNo, IsHandled);
       if IsHandled then
           exit(CustomerNo);

       if CustomerText = '' then
           exit('');

       if StrLen(CustomerText) <= MaxStrLen(Customer."No.") then
           if Customer.Get(CopyStr(CustomerText, 1, MaxStrLen(Customer."No."))) then
               exit(Customer."No.");

       OnGetCustNoOpenCardOnBeforeFilterCustomer(Customer);
       Customer.SetRange(Blocked, Customer.Blocked::" ");
       Customer.SetRange(Name, CustomerText);
       //-------------------------------------------------OnGetCustNoOpenCardOnBeforeCustomerFindFirst:BEGIN
       IsHandled := false;
       OnGetCustNoOpenCardOnBeforeCustomerFindFirst(Customer, IsHandled);
       if not IsHandled then
           if Customer.FindFirst() then
               exit(Customer."No.");
       //-------------------------------------------------OnGetCustNoOpenCardOnBeforeCustomerFindFirst:END

       Customer.SetCurrentKey(Name);

       CustomerWithoutQuote := ConvertStr(CustomerText, '''', '?');
       Customer.SetFilter(Name, '''@' + CustomerWithoutQuote + '''');
       OnGetCustNoOpenCardOnBeforeCustomerFindSet(Customer);
       if Customer.FindFirst() then
           exit(Customer."No.");
       Customer.SetRange(Name);

       CustomerFilterFromStart := '''@' + CustomerWithoutQuote + '*''';

       Customer.FilterGroup := -1;
       Customer.SetFilter("No.", CustomerFilterFromStart);

       Customer.SetFilter(Name, CustomerFilterFromStart);
       OnGetCustNoOpenCardOnAfterOnAfterCustomerFilterFromStart(Customer);

       if Customer.FindFirst() then
           if Customer.Count() = 1 then
               exit(Customer."No.");

       CustomerFilterContains := '''@*' + CustomerWithoutQuote + '*''';

       Customer.SetFilter("No.", CustomerFilterContains);
       Customer.SetFilter(Name, CustomerFilterContains);
       Customer.SetFilter(City, CustomerFilterContains);
       Customer.SetFilter(Contact, CustomerFilterContains);
       Customer.SetFilter("Phone No.", CustomerFilterContains);
       Customer.SetFilter("Post Code", CustomerFilterContains);
       OnGetCustNoOpenCardOnAfterSetCustomerFilters(Customer, CustomerFilterContains);

       if Customer.Count() = 0 then
           MarkCustomersWithSimilarName(Customer, CustomerText);

       if Customer.Count() = 1 then begin
           Customer.FindFirst();
           exit(Customer."No.");
       end;

       if not GuiAllowed() then
           Error(SelectCustErr);

       OnGetCustNoOpenCardOnAfterMarkCustomersWithSimilarName(Customer);

       if Customer.Count = 0 then begin
           if Customer.WritePermission then
               if ShowCreateCustomerOption then
                   case StrMenu(
                          StrSubstNo(
                            '%1,%2', StrSubstNo(CreateNewCustTxt, ConvertStr(CustomerText, ',', '.')), SelectCustTxt), 1, CustNotRegisteredTxt) of
                       0:
                           Error(SelectCustErr);
                       1:
                           exit(CreateNewCustomer(CopyStr(CustomerText, 1, MaxStrLen(Customer.Name)), ShowCustomerCard));
                   end
               else
                   exit('');
           Customer.Reset();
           NoFiltersApplied := true;
       end;

       if ShowCustomerCard then
           CustomerNo := PickCustomer(Customer, NoFiltersApplied)
       else begin
           LookupRequested := true;
           exit('');
       end;

       if CustomerNo <> '' then
           exit(CustomerNo);

       Error(SelectCustErr);
   end;

   //-------------------------------------------------OnGetCustNoOpenCardOnBeforeCustomerFindFirst:BEGIN
   [IntegrationEvent(false, false)]
   local procedure OnGetCustNoOpenCardOnBeforeCustomerFindFirst(var Customer: Record Customer; var IsHandled: Boolean)
   begin
   end;
   //-------------------------------------------------OnGetCustNoOpenCardOnBeforeCustomerFindFirst:END

[AleksandricMarko]

Hi @fridrichovsky,

Thanks for submitting this extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Alternatives Evaluated: Which existing events or patterns were tried and why they are insufficient for your scenario?
• Justification for IsHandled: Why is a standard event (without IsHandled) not sufficient? What specific technical reason requires bypass functionality? IsHandled events carry higher risk as they allow completely skipping business logic.
• Performance Considerations: What is the expected execution frequency of this procedure? What is the potential performance impact of event subscribers?
• Data Sensitivity Review: Please confirm that the exposed parameters don't contain sensitive data, or provide rationale if sensitive data exposure is necessary.
• Multi-Extension Interaction: What are the risks if multiple extensions subscribe to this event? How would conflicts be handled?

Please update the issue with the missing details. We'll automatically re-analyze once updated.

[fridrichovsky]

Hello @AleksandricMarko,
Reason for change is that search Customer by name generate more records so we don't want return first find customer. It is reason why we need change it to code bellow or we need add event.

•   if Customer.Find('-') and (Customer.Next() = 0) then
        exit(Customer."No.");

• Alternatives - There is now another option. Only copy whole function and do it ourself. It is bad idea.
• Justification for IsHandled - without isHandled is not possible skip unwanted exit from function there is no other events that isHandle skip so it is safe.
• Performance Considerations - If you speaking about performance I don't know frequency is. It depends on user speed how many times can click to action. This function suffer with more performance issues than what I want add:
  • First

  •   if Customer.FindFirst() then
          if Customer.Count() = 1 then
              exit(Customer."No.");

  • should be

  •   if Customer.Find('-') and (Customer.Next() = 0) then
          exit(Customer."No.");

  • Second

  •    if Customer.Count() = 0 then
           MarkCustomersWithSimilarName(Customer, CustomerText);

  • should be

  •    if Customer.IsEmpty() then
           MarkCustomersWithSimilarName(Customer, CustomerText);

  • Third

  •    if Customer.Count() = 1 then begin
           Customer.FindFirst();
           exit(Customer."No.");
       end;

  • should be

  •   if Customer.Find('-') and (Customer.Next() = 0) then
         exit(Customer."No.");

  • Fourth

  •    if Customer.Count = 0 then begin
           if Customer.WritePermission then
               if ShowCreateCustomerOption then
                   case StrMenu(
                          StrSubstNo(
                            '%1,%2', StrSubstNo(CreateNewCustTxt, ConvertStr(CustomerText, ',', '.')), SelectCustTxt), 1, CustNotRegisteredTxt) of
                       0:
                           Error(SelectCustErr);
                       1:
                           exit(CreateNewCustomer(CopyStr(CustomerText, 1, MaxStrLen(Customer.Name)), ShowCustomerCard));
                   end
               else
                   exit('');
           Customer.Reset();
           NoFiltersApplied := true;
       end;

  • should be

  •    if Customer.IsEmpty() then begin
           if Customer.WritePermission then
               if ShowCreateCustomerOption then
                   case StrMenu(
                          StrSubstNo(
                            '%1,%2', StrSubstNo(CreateNewCustTxt, ConvertStr(CustomerText, ',', '.')), SelectCustTxt), 1, CustNotRegisteredTxt) of
                       0:
                           Error(SelectCustErr);
                       1:
                           exit(CreateNewCustomer(CopyStr(CustomerText, 1, MaxStrLen(Customer.Name)), ShowCustomerCard));
                   end
               else
                   exit('');
           Customer.Reset();
           NoFiltersApplied := true;
       end;

• Data Sensitivity Review - Now there is no sensitive data
• Multi-Extension Interaction - Nothing

[AleksandricMarko]

Hi @fridrichovsky,

Thank you for providing additional information. However, the responses don't yet meet the quality standards required for IsHandled events. These events carry higher risk as they allow bypassing business logic, so we need more detailed justifications:

Still Missing or Insufficient:

1. Alternatives Evaluated: Your response "There is now another option. Only copy whole function and do it ourself. It is bad idea." is unclear. Please clearly explain:

   • Which existing events or extension patterns you tried
   • Why each alternative is insufficient for your specific scenario

2. Justification for IsHandled: Your response "without isHandled is not possible skip unwanted exit from function there is no other events that isHandle skip so it is safe." doesn't explain WHY from a business/technical perspective. Please provide:

   • Specific technical reason why a standard event is insufficient
   • Concrete business logic that must be skipped/replaced
   • Exact scenario where bypass is essential
   • Why alternative approaches won't work

   Example of good justification: "We must bypass the standard credit limit check because our vertical industry (healthcare) requires real-time insurance pre-authorization instead. The standard check would block orders that are actually covered by insurance, but there's no way to inject our authorization logic before the credit check fails."

3. Multi-Extension Interaction: Your response "Nothing" is insufficient. Please explain:

   • What risks exist if multiple extensions subscribe to this event?
   • How would conflicts be mitigated?
   • IsHandled events are particularly sensitive in multi-extension scenarios

Please update your responses with these details. We'll automatically re-analyze once updated.