test: fix hostname (#640)

Kikobeats · web-flow · commit 50d75d70f1ae · 2025-12-02T11:35:59.000+01:00
diff --git a/packages/browserless/test/index.js b/packages/browserless/test/index.js
@@ -46,7 +46,10 @@ test('pass specific options to a context', async t => {
     res.end('<html><body><h1>origin server reached</h1></body></html>')
   })
 
-  const browserless = await getBrowserContext(t, { proxyServer: proxyUrl.slice(0, -1) })
+  const browserless = await getBrowserContext(t, {
+    proxyServer: proxyUrl.slice(0, -1),
+    proxyBypassList: ['<-loopback>']
+  })
   const text = await browserless.text(url)
 
   t.is(text, 'origin server reached')
diff --git a/packages/browserless/test/snapshots/index.js.md b/packages/browserless/test/snapshots/index.js.md
@@ -36,4 +36,6 @@ Generated by [AVA](https://avajs.dev).
 
 > Snapshot 1
 
-    'hello world'
+    `hello world␊
+    ␊
+    -- 1 of 1 --`
diff --git a/packages/browserless/test/snapshots/index.js.snap b/packages/browserless/test/snapshots/index.js.snap
diff --git a/packages/test/index.js b/packages/test/index.js
@@ -1,9 +1,9 @@
 'use strict'
 
 const { imgDiff } = require('img-diff-js')
+const { PDFParse } = require('pdf-parse')
 const { onExit } = require('signal-exit')
 const { runServer } = require('./util')
-const { pdf } = require('pdf-parse')
 const { copy } = require('fs-extra')
 const temp = require('temperment')
 const path = require('path')
@@ -135,7 +135,9 @@ module.exports = (browser, teardown = browser.close) => {
     const url = await getUrl(t)
     const buffer = await browserless.pdf(url)
 
-    const data = await pdf(buffer)
+    const parser = new PDFParse({ data: buffer })
+    await parser.load()
+    const data = await parser.getText()
 
     t.snapshot(data.text.trim())
   })
diff --git a/packages/test/util/create.js b/packages/test/util/create.js
@@ -3,26 +3,9 @@
 const { default: listen } = require('async-listen')
 const { onExit } = require('signal-exit')
 const { createServer } = require('http')
-const os = require('os')
 
 const closeServer = server => require('util').promisify(server.close.bind(server))()
 
-let HOSTNAME = os.hostname()
-
-// Hostname might not be always accessible in environments other than GitHub
-// Actions. Therefore, we try to find an external IPv4 address to be used as a
-// hostname in these tests.
-const networkInterfaces = os.networkInterfaces()
-for (const key of Object.keys(networkInterfaces)) {
-  const interfaces = networkInterfaces[key]
-  for (const net of interfaces || []) {
-    if (net.family === 'IPv4' && !net.internal) {
-      HOSTNAME = net.address
-      break
-    }
-  }
-}
-
 const runServer = async (t, handler) => {
   const server = createServer(async (req, res) => {
     try {
@@ -35,7 +18,7 @@ const runServer = async (t, handler) => {
   })
 
   const url = await listen(server)
-  url.hostname = HOSTNAME
+  url.hostname = '127.0.0.1'
 
   t.teardown(() => closeServer(server))
   return url.toString()
