Bunch of improvements to backward ray tracers #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MennoVeerman
commented
Jul 18, 2024
•
MennoVeerman
commented
- add option to obtain slanted LWP and cloud optical depth, and distance to nearest cloud, for each camera pixel
- dividing broadband radiance by sun solid angle, now we actually get radiances
- enable bw raytracer to compute xyz and radiance in one go, rather than requiring two subsequent runs
…aths for each camera pixel
…date_to_reference
…t rounding issues
…ton to domain top
…ed cloud properties without running the raytracing
…d distance to closest cloudy cell
…al radiance in W/m2/sr
…tead of one of the two
MennoVeerman
changed the title
…n raytracing domain with optical properties integrated from TOD to TOA. Thanks to Robert Pincus for the suggestion
Chiil
reviewed
Oct 1, 2024
|
|
||
| if ( (icol_x < grid_cells.x) && (icol_y < grid_cells.y) && (iz < grid_cells.z) ) | ||
| if ( (icol_x < grid_cells.x) && (icol_y < grid_cells.y) && (iz < (grid_cells.z - 1)) ) |
There was a problem hiding this comment.
Why z-1? Is because out of domain means entering the top layer? If so, the new config allows for TOA fluxes instead of TOD, do we want that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.