Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscription problem #503

Closed
fztcjjl opened this issue Jun 8, 2019 · 8 comments
Closed

subscription problem #503

fztcjjl opened this issue Jun 8, 2019 · 8 comments

Comments

@fztcjjl
Copy link
Contributor

fztcjjl commented Jun 8, 2019

When the service is disconnected from the messaging system, the subscription needs to be resubscribed after reconnection. So there should be provide a way to resubscribe topic.

@vtolstov
Copy link
Contributor

vtolstov commented Jun 8, 2019

This is not simple, because we need to store topic and options for subscription..
I'm need to think about this more

@vtolstov vtolstov closed this as completed Jun 8, 2019
@vtolstov vtolstov reopened this Jun 8, 2019
@fztcjjl
Copy link
Contributor Author

fztcjjl commented Jun 8, 2019

topic and subscription options has already stored in server。
eg.

subscribers map[*subscriber][]broker.Subscriber

@vtolstov
Copy link
Contributor

vtolstov commented Jun 8, 2019 via email

@vtolstov
Copy link
Contributor

i think that we need to fix this in stan broker in nats-io/stan.go repo (as devs says in slack nats already resubscribe after reconnect)

@vtolstov
Copy link
Contributor

i'm create issue to stan.go nats-io/stan.go#273

@asim
Copy link
Member

asim commented Jul 21, 2019

Marking this as a non-fix for now. The complexity of managing reconnection and resubscription is quite tough, especially across pluggable tooling.

@asim asim closed this as completed Jul 21, 2019
@vtolstov
Copy link
Contributor

i think before closing this issue we need to document current behavior and add some stuff to development repo as issue?

@asim
Copy link
Member

asim commented Jul 21, 2019

Closing this is fine. Add to development repo if needed. But otherwise it's fairly complex and difficult to implement across all brokers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants