Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve developer experience by avoiding "Unresolved var" warnings by clj-kondo #218

Closed
jacobemcken opened this issue Sep 4, 2022 · 2 comments · Fixed by #220
Closed

Improve developer experience by avoiding "Unresolved var" warnings by clj-kondo #218

jacobemcken opened this issue Sep 4, 2022 · 2 comments · Fixed by #220

Comments

@jacobemcken
Copy link
Contributor

Since all operators are created using the macro defoperator in the monger.operators namespace, the IDE doesn't know that these symbols actually exists (and clj-kondo complains about stuff like Unresolved var: $inc).

Would you be interested in a PR that declares all operators, kinda like so:

(declare $gt $gte $lt $lte ...
...
(defoperator $gt)
(defoperator $gte)
(defoperator $lt)
(defoperator $lte)
...

This ensures symbols can be seen by the IDE to improve the developer experience (e.g. easily noticing a typo in an operator).
@michaelklishin
Copy link
Owner

Sure, why not. Thank you.

@Deraen
Copy link
Contributor

Deraen commented Sep 7, 2022

This and #210 would be indeed nice to improve dev experience with clj-kondo.

@jacobemcken jacobemcken mentioned this issue Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid linter warning about unresolved operator jacobemcken/monger
3 participants
@michaelklishin @Deraen @jacobemcken