Add grouping and decimal separators (#31)

## About Adds the ability to set the grouping and decimal separators. ---
michael-rubel · Jul 27, 2023 · b440f8d · b440f8d
1 parent 796a489
commit b440f8d
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/src/Collection/LocaleNumberFormatter.php b/src/Collection/LocaleNumberFormatter.php
@@ -21,13 +21,17 @@ class LocaleNumberFormatter implements Formatter
      * @param  int  $style
      * @param  string|null  $pattern
      * @param  int  $fraction_digits
+     * @param  string|null  $grouping_separator
+     * @param  string|null  $decimal_separator
      */
     public function __construct(
         public int|float|string|null $number = null,
         public ?string $locale = null,
         public int $style = NumberFormatter::DECIMAL,
         public ?string $pattern = null,
         public int $fraction_digits = 2,
+        public ?string $grouping_separator = null,
+        public ?string $decimal_separator = null,
     ) {
     }
 
@@ -44,6 +48,14 @@ public function format(Collection $items): string|false
 
         $this->formatter->setAttribute(NumberFormatter::FRACTION_DIGITS, $this->fraction_digits);
 
+        if ($this->grouping_separator) {
+            $this->formatter->setSymbol(NumberFormatter::GROUPING_SEPARATOR_SYMBOL, $this->grouping_separator);
+        }
+
+        if ($this->decimal_separator) {
+            $this->formatter->setSymbol(NumberFormatter::DECIMAL_SEPARATOR_SYMBOL, $this->decimal_separator);
+        }
+
         return $this->formatter->format(
             (float) $this->number
         );

diff --git a/tests/LocaleNumberFormatterTest.php b/tests/LocaleNumberFormatterTest.php
@@ -198,4 +198,20 @@ public function testCanExtendLocaleNumberFormatter()
 
         $this->assertEquals('10 000,56', $result);
     }
+
+    /** @test */
+    public function testCanSetGroupingAndDecimalSeparatorUsingExtend()
+    {
+        $this->app->extend(LocaleNumberFormatter::class, function (LocaleNumberFormatter $formatter) {
+            $formatter->locale             = 'en';
+            $formatter->grouping_separator = '-';
+            $formatter->decimal_separator  = ',';
+
+            return $formatter;
+        });
+
+        $result = format(LocaleNumberFormatter::class, 10000.5550);
+
+        $this->assertEquals('10-000,56', $result);
+    }
 }