From 9fc3ca85e324388dd243ebbf8031093ff8e23261 Mon Sep 17 00:00:00 2001 From: michael-hawker <24302614+michael-hawker@users.noreply.github.com> Date: Tue, 14 Mar 2023 13:02:20 -0700 Subject: [PATCH] Disable warning for CA1001 with disposible in TransitionHelper See https://github.com/CommunityToolkit/Labs-Windows/issues/407 --- .../src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj | 4 ++++ components/TransitionHelper/src/TransitionHelper.cs | 2 +- tooling | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj b/components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj index cdeb5426a..21bdbf281 100644 --- a/components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj +++ b/components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj @@ -6,6 +6,10 @@ CommunityToolkit.Labs.WinUI.TransitionHelperRns + + + + $(NoWarn);CA1001 diff --git a/components/TransitionHelper/src/TransitionHelper.cs b/components/TransitionHelper/src/TransitionHelper.cs index 06fbb6de5..e4f704ab7 100644 --- a/components/TransitionHelper/src/TransitionHelper.cs +++ b/components/TransitionHelper/src/TransitionHelper.cs @@ -10,7 +10,7 @@ namespace CommunityToolkit.Labs.WinUI; /// A animation helper that morphs between two controls. /// [ContentProperty(Name = nameof(Configs))] -public sealed partial class TransitionHelper +public sealed partial class TransitionHelper // TODO: Implement IDisposible? or resolve CA1001 another way? { private sealed record AnimatedElements( IDictionary ConnectedElements, diff --git a/tooling b/tooling index d34f72568..66ab9faeb 160000 --- a/tooling +++ b/tooling @@ -1 +1 @@ -Subproject commit d34f72568e654a4a65d8804d8f145ac76032100c +Subproject commit 66ab9faebbcf0118e66008bfa194c1fa2b9b06f0