Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizing the App Functionality #1

Open
davidfateh opened this issue Jan 14, 2021 · 1 comment
Open

Generalizing the App Functionality #1

davidfateh opened this issue Jan 14, 2021 · 1 comment

Comments

@davidfateh
Copy link
Contributor

Hey Martin!

Big fan of what you've done here and I'm happy to see that that live stream has given you some inspiration. :)

When working on that ingredients app, our main idea behind it was to enable an app to allow for a repeatable field much like the one you've created. One of our ideas here is to generalize the functionality to extend beyond just ingredient lists and create an app that has very similar UX to the one you've built but allows for customization of labels and fields to fit into all different kinds of contexts.

I wanted to give you a heads up that I'm going to fork this repo and play around with it a bit to try and produce something close to what I'm talking about. I would love to get your thoughts on the matter as well as send over a PR when I've got some more concrete functionality working.

@mgschoen
Copy link
Owner

Hi David, thanks for reaching out! Happy to read you liked it.

I was already planning on generalizing the app a little, but as I will probably never get around to actually do it on my own, I would be happy about your contribution :)

My next ups were:

  • keep the structure, but make the labels and JSON keys configurable
  • keep the number of keys per row, but make the field types (text or reference) configurable
  • make the number of keys configurable
  • add more field types

Does that seem like the direction you imagined it to go?

I did not do the research yet as to where that configuration would take place, but it seems "Instance parameter definitions" could be a good start, am I right?

Also, what bothers me is the mixture of Typescript and Javascript in the repo. I was new to both React and Typescript, so I decided to only wrestle with one of them. But feel free to reintroduce typescript if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants