Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ClientProxyFactory.CreateProxy so it has some specific HttpClientHandlers #27

Open
2 tasks
shiggan opened this issue Nov 1, 2018 · 0 comments
Open
2 tasks

Refactor ClientProxyFactory.CreateProxy so it has some specific HttpClientHandlers #27

shiggan opened this issue Nov 1, 2018 · 0 comments
Labels
enhancement New feature or request
Projects
work in progress
Milestone
1.0

Comments

@shiggan
Copy link
Contributor

shiggan commented Nov 1, 2018

Currently ClientProxyFactory.CreateProxy just creates the refit proxy; with a SimpleAccessTokenHttpClientHandler change it so that

  • Logging Client Handler - records intention (api being called); preformance; success or error logs
  • Retry Client Handler - create a default polly http client handler

Mabye a new IProxyCreator.CreateProxy which could be passed into the ClientProxyFactory (which is intended to only handle creating-caching / re using existing keyed proxies) ?
@shiggan shiggan added the enhancement New feature or request label Nov 1, 2018
@shiggan shiggan added this to the 1.0 milestone Nov 1, 2018
@shiggan shiggan added this to backlog in work in progress via automation Nov 1, 2018
shiggan added a commit that referenced this issue Nov 1, 2018
@shiggan
adding note for #27
f1156e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
work in progress
  
backlog
Milestone
1.0
Development

No branches or pull requests
1 participant
@shiggan