Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

larger source files cause failure to delete backup files when doing :w #689

Closed
reiend opened this issue Oct 24, 2024 · 2 comments
Closed

Comments

@reiend
Copy link

reiend commented Oct 24, 2024

I pinpoint the issue by removing all of my plugins except nvim-lint
this happen when doing :w

linter - clang-tidy
file size - 16.94kb
lines - 544
nvim - 0.10.2v
os - windows
shell - powershell
terminal - windows terminal

config

local plugin = require 'lint'

plugin.linters.clangtidy.args = {
  '-p',
  'build',
}

plugin.linters_by_ft = {
  lua = { 'luacheck' },
  c = { 'clangtidy' },
  cpp = { 'clangtidy' },
  javascript = { 'eslint_d' },
  javascriptreact = { 'eslint_d' },
  typescript = { 'eslint_d' },
  typescriptreact = { 'eslint_d' },
}

vim.api.nvim_create_autocmd({ 'BufWritePost' }, {
  callback = function()
    -- try_lint without arguments runs the linters defined in `linters_by_ft`
    -- for the current filetype
    require('lint').try_lint()
  end,
})

will try to recreate the same thing in linux.

@reiend reiend changed the title Larger source files cause failure to delete backup files larger source files cause failure to delete backup files Oct 24, 2024
@reiend reiend changed the title larger source files cause failure to delete backup files larger source files cause failure to delete backup files when doing :w Oct 24, 2024
@reiend
Copy link
Author

reiend commented Oct 24, 2024

I pinpoint the issue by removing all of my plugins except nvim-lint this happen when doing :w

linter - clang-tidy file size - 16.94kb lines - 544 nvim - 0.10.2v os - windows shell - powershell terminal - windows terminal

config

local plugin = require 'lint'

plugin.linters.clangtidy.args = {
  '-p',
  'build',
}

plugin.linters_by_ft = {
  lua = { 'luacheck' },
  c = { 'clangtidy' },
  cpp = { 'clangtidy' },
  javascript = { 'eslint_d' },
  javascriptreact = { 'eslint_d' },
  typescript = { 'eslint_d' },
  typescriptreact = { 'eslint_d' },
}

vim.api.nvim_create_autocmd({ 'BufWritePost' }, {
  callback = function()
    -- try_lint without arguments runs the linters defined in `linters_by_ft`
    -- for the current filetype
    require('lint').try_lint()
  end,
})

will try to recreate the same thing in linux.

I tried this setup below in linux
linter - clang-tidy
file size - 16.94kb
lines - 544
nvim - 0.10.2v

it works fine.

@mfussenegger
Copy link
Owner

I don't use/have windows so I cannot look into this. My best guess is that spawing clang-tidy with the filepath causes windows to "lock" the file, causing issues with the backup mechanism. If that's the case I'm also not sure if there's much that can be done on nvim-lint side.

If anyone has a fix for this a PR would be welcome, but I'm not going to spend time on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants