fix: convert Copr project name into cached property

And also make it abstract property at the same time.

Signed-off-by: Matej Focko <[email protected]>

Author: mfocko

src/validation/testcase/base.py

@@ -46,18 +46,6 @@ def __init__(
         self._build = None
         self._statuses: list[GithubCheckRun] | list[CommitFlag] = []
 
-    @property
-    def copr_project_name(self):
-        """
-        Get the name of Copr project from id of the PR.
-
-        Returns:
-            Copr project name.
-        """
-        if self.pr and not self._copr_project_name:
-            self._copr_project_name = self.construct_copr_project_name()
-        return self._copr_project_name
-
     async def run_test(self):
         """
         Run all checks, if there is any failure message, send it to Sentry and in case of
@@ -379,7 +367,14 @@ async def watch_statuses(self):
     @abstractmethod
     def account_name(self):
         """
-        Get the name of the (bot) account in GitHub/GitLab.
+        Name of the (bot) account in GitHub/GitLab.
+        """
+
+    @property
+    @abstractmethod
+    def copr_project_name(self):
+        """
+        Name of Copr project from id of the PR.
         """
 
     @abstractmethod
@@ -418,12 +413,6 @@ def update_file_and_commit(self, path: str, commit_msg: str, content: str, branc
         Update a file via API (creates new commit).
         """
 
-    @abstractmethod
-    def construct_copr_project_name(self) -> str:
-        """
-        Construct the Copr project name for the PR to check.
-        """
-
     @abstractmethod
     def get_status_name(self, status: Union[GithubCheckRun, CommitFlag]) -> str:
         """

src/validation/testcase/github.py

@@ -2,6 +2,8 @@
 #
 # SPDX-License-Identifier: MIT
 
+from functools import cached_property
+
 from github import InputGitAuthor
 from github.Commit import Commit
 from ogr.services.github import GithubProject
@@ -22,12 +24,13 @@ class GithubTestcase(Testcase):
     def account_name(self):
         return self.deployment.github_bot_name
 
+    @cached_property
+    def copr_project_name(self) -> str:
+        return f"packit-hello-world-{self.pr.id}"
+
     def get_status_name(self, status: GithubCheckRun) -> str:
         return status.name
 
-    def construct_copr_project_name(self) -> str:
-        return f"packit-hello-world-{self.pr.id}"
-
     def create_empty_commit(self, branch: str, commit_msg: str) -> str:
         contents = self.project.github_repo.get_contents("test.txt", ref=branch)
         # https://pygithub.readthedocs.io/en/latest/examples/Repository.html#update-a-file-in-the-repository

src/validation/testcase/gitlab.py

@@ -2,6 +2,8 @@
 #
 # SPDX-License-Identifier: MIT
 
+from functools import cached_property
+
 from gitlab import GitlabGetError
 from ogr.abstract import CommitFlag, CommitStatus
 from ogr.services.gitlab import GitlabProject
@@ -16,12 +18,13 @@ class GitlabTestcase(Testcase):
     def account_name(self):
         return self.deployment.gitlab_account_name
 
+    @cached_property
+    def copr_project_name(self) -> str:
+        return f"{self.project.service.hostname}-{self.project.namespace}-hello-world-{self.pr.id}"
+
     def get_status_name(self, status: CommitFlag) -> str:
         return status.context
 
-    def construct_copr_project_name(self) -> str:
-        return f"{self.project.service.hostname}-{self.project.namespace}-hello-world-{self.pr.id}"
-
     def create_file_in_new_branch(self, branch: str):
         self.pr_branch_ref = self.project.gitlab_repo.branches.create(
             {"branch": branch, "ref": "master"},