Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuplicateRouteDetector has no tests 馃槺 #47

Open
gsteel opened this issue Mar 29, 2023 · 2 comments
Open

DuplicateRouteDetector has no tests 馃槺 #47

gsteel opened this issue Mar 29, 2023 · 2 comments
Labels
Enhancement New feature or request

Comments

@gsteel
Copy link
Member

gsteel commented Mar 29, 2023

No description provided.

@gsteel gsteel added the Enhancement New feature or request label Mar 29, 2023
@boesing
Copy link
Member

boesing commented Mar 29, 2023

Its indirectly tested via the RouteCollectorTest tho.
bb9bce2

Not saying it should be like this, just that it is kinda tested. But TBH, the whole class should have been @internal as I would not expect that this is a service we should provide without an interface.

@gsteel
Copy link
Member Author

gsteel commented Mar 29, 2023

Yes, I since noticed the indirect tests - I ran coverage locally and it came out at 0% because of the #[CoversClass] on the collector test case. I'll add an issue to mark it as internal for 4.0.0

@gsteel gsteel mentioned this issue Mar 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boesing @gsteel