Testing for OnChange on OnEnterKey events for textarea and textinput.

Author: rj

textarea_test.go

@@ -1,6 +1,7 @@
 package goey
 
 import (
+	"bytes"
 	"testing"
 
 	"bitbucket.org/rj/goey/base"
@@ -17,15 +18,30 @@ func TestTextAreaMount(t *testing.T) {
 	)
 }
 
-func TestTextAreaEvents(t *testing.T) {
+func TestTextAreaOnFocus(t *testing.T) {
 	testingCheckFocusAndBlur(t,
 		&TextArea{},
 		&TextArea{},
 		&TextArea{},
 	)
 }
 
-func TestTextAreaProps(t *testing.T) {
+func TestTextAreaOnChange(t *testing.T) {
+	log := bytes.NewBuffer(nil)
+
+	testingTypeKeys(t, "Hello",
+		&TextArea{OnChange: func(v string) {
+			log.WriteString(v)
+			log.WriteString("\x1E")
+		}})
+
+	const want = "H\x1EHe\x1EHel\x1EHell\x1EHello\x1E"
+	if got := log.String(); got != want {
+		t.Errorf("Wanted %v, got %v", want, got)
+	}
+}
+
+func TestTextAreaUpdateProps(t *testing.T) {
 	testingUpdateWidgets(t, []base.Widget{
 		&TextArea{Value: "A", MinLines: 5},
 		&TextArea{Value: "B", MinLines: 3, Placeholder: "..."},

textinput_test.go

@@ -1,6 +1,7 @@
 package goey
 
 import (
+	"bytes"
 	"fmt"
 	"testing"
 
@@ -64,15 +65,44 @@ func TestTextInputClose(t *testing.T) {
 	)
 }
 
-func TestTextInputEvents(t *testing.T) {
+func TestTextInputOnFocus(t *testing.T) {
 	testingCheckFocusAndBlur(t,
 		&TextInput{},
 		&TextInput{},
 		&TextInput{},
 	)
 }
 
-func TestTextInputProps(t *testing.T) {
+func TestTextInputOnChange(t *testing.T) {
+	log := bytes.NewBuffer(nil)
+
+	testingTypeKeys(t, "Hello",
+		&TextInput{OnChange: func(v string) {
+			log.WriteString(v)
+			log.WriteString("\x1E")
+		}})
+
+	const want = "H\x1EHe\x1EHel\x1EHell\x1EHello\x1E"
+	if got := log.String(); got != want {
+		t.Errorf("Wanted %v, got %v", want, got)
+	}
+}
+
+func TestTextInputOnEnterKey(t *testing.T) {
+	log := bytes.NewBuffer(nil)
+
+	testingTypeKeys(t, "Hello\n",
+		&TextInput{OnEnterKey: func(v string) {
+			log.WriteString(v)
+		}})
+
+	const want = "Hello"
+	if got := log.String(); got != want {
+		t.Errorf("Wanted %v, got %v", want, got)
+	}
+}
+
+func TestTextInputUpdateProps(t *testing.T) {
 	testingUpdateWidgets(t, []base.Widget{
 		&TextInput{Value: "A"},
 		&TextInput{Value: "B", Placeholder: "..."},

widget_test.go

@@ -23,6 +23,10 @@ type Focusable interface {
 	TakeFocus() bool
 }
 
+type Typeable interface {
+	TypeKeys(text string) chan error
+}
+
 func equal(t *testing.T, lhs, rhs base.Widget) bool {
 	if runtime.GOOS == "windows" {
 		// On windows, the message EM_GETCUEBANNER does not work unless the manifest
@@ -229,6 +233,7 @@ func testingCloseWidgets(t *testing.T, widgets ...base.Widget) {
 
 func testingCheckFocusAndBlur(t *testing.T, widgets ...base.Widget) {
 	log := bytes.NewBuffer(nil)
+	skipFlag := false
 
 	for i := byte(0); i < 3; i++ {
 		s := reflect.ValueOf(widgets[i])
@@ -259,7 +264,7 @@ func testingCheckFocusAndBlur(t *testing.T, widgets ...base.Widget) {
 							t.Errorf("Failed to set focus on the control")
 						}
 					} else {
-						t.Errorf("Control does not support TakeFocus")
+						skipFlag = true
 					}
 					return nil
 				})
@@ -285,14 +290,72 @@ func testingCheckFocusAndBlur(t *testing.T, widgets ...base.Widget) {
 	if err != nil {
 		t.Errorf("Failed to run GUI loop, %s", err)
 	}
+	if skipFlag {
+		t.Skip("Control does not support TakeFocus")
+	}
+
 	const want = "fabafbbbfcbc"
 	if s := log.String(); s != want {
 		t.Errorf("Incorrect log string, want %s, got log==%s", want, s)
 	}
 }
 
+func testingTypeKeys(t *testing.T, text string, widget base.Widget) {
+	skipFlag := false
+
+	init := func() error {
+		window, err := NewWindow(t.Name(), &VBox{Children: []base.Widget{widget}})
+		if err != nil {
+			t.Errorf("Failed to create window, %s", err)
+		}
+
+		var typingErr chan error
+		go func(window *Window) {
+			err := loop.Do(func() error {
+				child := window.child.(*vboxElement).children[0]
+				if elem, ok := child.(Typeable); ok {
+					typingErr = elem.TypeKeys(text)
+				} else {
+					skipFlag = true
+				}
+				return nil
+			})
+			if err != nil {
+				t.Errorf("Error in Do, %s", err)
+			}
+
+			// Wait for typing to complete, and check for errors
+			if typingErr != nil {
+				for v := range typingErr {
+					t.Errorf("Failed to type keys on the control, %v", v)
+				}
+			}
+
+			// Close the window
+			err = loop.Do(func() error {
+				window.Close()
+				return nil
+			})
+			if err != nil {
+				t.Errorf("Error in Do, %s", err)
+			}
+		}(window)
+
+		return nil
+	}
+
+	err := loop.Run(init)
+	if err != nil {
+		t.Errorf("Failed to run GUI loop, %s", err)
+	}
+	if skipFlag {
+		t.Skip("Control does not support TypeKeys")
+	}
+}
+
 func testingCheckClick(t *testing.T, widgets ...base.Widget) {
 	log := bytes.NewBuffer(nil)
+	skipFlag := false
 
 	for i := byte(0); i < 3; i++ {
 		letter := 'a' + i
@@ -327,7 +390,7 @@ func testingCheckClick(t *testing.T, widgets ...base.Widget) {
 					if elem, ok := child.(Clickable); ok {
 						elem.Click()
 					} else {
-						t.Errorf("Control does not support Click")
+						skipFlag = true
 					}
 					return nil
 				})
@@ -353,6 +416,10 @@ func testingCheckClick(t *testing.T, widgets ...base.Widget) {
 	if err != nil {
 		t.Errorf("Failed to run GUI loop, %s", err)
 	}
+	if skipFlag {
+		t.Skip("Control does not support Click")
+	}
+
 	const want = "cacbcc"
 	if s := log.String(); s != want {
 		t.Errorf("Incorrect log string, want %s, got log==%s", want, s)

widget_windows.go

@@ -1,11 +1,14 @@
 package goey
 
 import (
+	"fmt"
 	"syscall"
+	"time"
 	"unsafe"
 
 	"bitbucket.org/rj/goey/base"
 	win2 "bitbucket.org/rj/goey/internal/syscall"
+	"bitbucket.org/rj/goey/loop"
 	"github.com/lxn/win"
 )
 
@@ -72,6 +75,51 @@ func (w *Control) TakeFocus() bool {
 	return win.SetFocus(w.hWnd) != 0
 }
 
+func (w *Control) TypeKeys(text string) chan error {
+	err := make(chan error, 1)
+
+	go func() {
+		defer close(err)
+
+		loop.Do(func() error {
+			if !w.TakeFocus() {
+				err <- fmt.Errorf("windows error on take focus, %x", win.GetLastError())
+			}
+			return nil
+		})
+
+		time.Sleep(10 * time.Millisecond)
+		for _, r := range text {
+			inp := [2]win.KEYBD_INPUT{
+				{win.INPUT_KEYBOARD, win.KEYBDINPUT{}},
+				{win.INPUT_KEYBOARD, win.KEYBDINPUT{}},
+			}
+
+			if r == '\n' {
+				inp[0].Ki.WVk = win.VK_RETURN
+				inp[1].Ki.WVk = win.VK_RETURN
+				inp[1].Ki.DwFlags = win.KEYEVENTF_KEYUP
+			} else {
+				inp[0].Ki.WScan = uint16(r)
+				inp[0].Ki.DwFlags = win.KEYEVENTF_UNICODE
+				inp[1].Ki.WScan = uint16(r)
+				inp[1].Ki.DwFlags = win.KEYEVENTF_UNICODE | win.KEYEVENTF_KEYUP
+			}
+
+			loop.Do(func() error {
+				rc := win.SendInput(2, unsafe.Pointer(&inp), int32(unsafe.Sizeof(inp[0])))
+				if rc != 2 {
+					err <- fmt.Errorf("windows error, %x", win.GetLastError())
+				}
+				return nil
+			})
+			time.Sleep(10 * time.Millisecond)
+		}
+	}()
+
+	return err
+}
+
 // SetOrder is a call around SetWindowPos used to ensure that a window appears
 // in the correct order.
 func (w *Control) SetOrder(previous win.HWND) win.HWND {