localhost:8000/posts not display all records

[gfmoore]

Hi, just experimenting. Found that the code won't display all the records when used without the /1

This seemed because it was trying to do a SELECT * WHERE id="NULL"

so I stuck the following code in:

switch (req.method) {
case 'GET':
if (key === "NULL") {
sql = "select * from " + table;
}
else {
sql = "select * from " + table + (key ? " where id=" + key : '');
}
break;

Hope this makes sense.

There may be a more elegant way :)

ps I just want to say thanks for all the work you have done on this project - I've found it very useful for my personal projects and learning about RESTful services. Thanks.

[mevdschee]

Thank you for your question and your compliments. The following code:

(key ? " where id=" + key : '')

means that there is no "where" clause when "key" is an empty string.

[gfmoore]

Oh yes of course - a pattern I don't use, but not sure why?

However, I am still getting an id = "NULL" and it comes at this point

var table = req.db.escapeId(request.shift());

this gets the table gmusers fine, but then

var key = req.db.escape(request.shift()); //here is problem for me

since the array (request) is now empty this is putting 'NULL' into the key and not ''

this occcurs whether the url is localhost://gmusers or localhost://gmusers/

where gmusers is my very simple mysql table

I'm assuming that you expected that 'key' would be filled with an empty string here?

Also in looking up the documentation I noted that 'escape' is now deprecated (could this be where it falls apart?) and that encodeURI() or encodeURIComponent() should be used. (btw I couldn't get either to work, but mayhap I'm using it wrong.) (Not sure this is relevant anyway.)
Ahhh just found that encodeURI doesn't exist in Node, so escape is fine - my bad, sorry.

Any thoughts would be appreciated. I'm glad too that you are still taking an interest in this code :)