Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type errors when adding additional dayjs plugins #45

Open
KieranP opened this issue Jul 1, 2024 · 0 comments
Open

Type errors when adding additional dayjs plugins #45

KieranP opened this issue Jul 1, 2024 · 0 comments

Comments

@KieranP
Copy link

KieranP commented Jul 1, 2024

  import { svelteTime, dayjs } from 'svelte-time'

  import localizedFormat from 'dayjs/esm/plugin/localizedFormat'
  dayjs.extend(localizedFormat)

  import timezone from 'dayjs/esm/plugin/timezone'
  dayjs.extend(timezone)

  <time
    use:svelteTime=({
      ...
    })
  />
/work/app/frontend/javascripts/components/date_time.svelte:6:16
Error: Argument of type 'PluginFunc' is not assignable to parameter of type 'PluginFunc<unknown>'.
  Types of parameters 'c' and 'c' are incompatible.
    Type 'typeof import("/work/node_modules/svelte-time/node_modules/dayjs/esm/index").Dayjs' is not assignable to type 'typeof import("/work/node_modules/dayjs/esm/index").Dayjs'.
      Types of construct signatures are incompatible.
        Type 'new (config?: string | number | Date | Dayjs | null | undefined) => Dayjs' is not assignable to type 'new (config?: string | number | Date | Dayjs | null | undefined) => Dayjs'.
          Types of parameters 'config' and 'config' are incompatible.
            Type 'string | number | Date | import("/work/node_modules/dayjs/esm/index").Dayjs | null | undefined' is not assignable to type 'string | number | Date | import("/work/node_modules/svelte-time/node_modules/dayjs/esm/index").Dayjs | null | undefined'.
              Type 'Dayjs' is not assignable to type 'string | number | Date | Dayjs | null | undefined'.
                Type 'Dayjs' is missing the following properties from type 'Dayjs': fromNow, from, toNow, to (ts)

/work/app/frontend/javascripts/components/date_time.svelte:9:16
Error: Argument of type 'PluginFunc' is not assignable to parameter of type 'PluginFunc<unknown>'. (ts)

Adding import dayjs from 'dayjs/esm' at the top fixes the type errors, but then the plugins won't be active and give the correct result.

Would be handy if I could construct and pass in dayjs:

  import dayjs from 'dayjs/esm'

  import localizedFormat from 'dayjs/esm/plugin/localizedFormat'
  dayjs.extend(localizedFormat)

  import timezone from 'dayjs/esm/plugin/timezone'
  dayjs.extend(timezone)

  import { svelteTime } from 'svelte-time'

  <time
    use:svelteTime=({
      dayjs,
      ...
    })
  />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant