Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function substring- functions are not implemented in Metapath processor #132

Closed
8 tasks done
Tracked by #734
aj-stein-gsa opened this issue Sep 27, 2024 · 2 comments · Fixed by #142
Closed
8 tasks done
Tracked by #734

Function substring- functions are not implemented in Metapath processor #132

aj-stein-gsa opened this issue Sep 27, 2024 · 2 comments · Fixed by #142
Assignees
@aj-stein-gsa
Labels
enhancement New feature or request java Pull requests that update Java code
Milestone
v1.2.0

Comments

@aj-stein-gsa
Copy link
Contributor

aj-stein-gsa commented Sep 27, 2024 •
edited
Loading

User Story

As a developer of Metaschema-based software, in order to write more efficient and easier to read Metapath in my models, I would like this library to implement the function substring-after().

Goals

Dependencies

N/A

Acceptance Criteria

  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
  • All website and readme documentation affected by the changes in this issue have been updated.

Revisions

No response
@aj-stein-gsa aj-stein-gsa added enhancement New feature or request java Pull requests that update Java code labels Sep 27, 2024
@aj-stein-gsa aj-stein-gsa mentioned this issue Sep 27, 2024
Closed
16 tasks
@aj-stein-gsa aj-stein-gsa self-assigned this Sep 27, 2024
@david-waltermire david-waltermire added this to the v1.2.0 milestone Sep 27, 2024
@david-waltermire david-waltermire moved this from To Triage to Ready in Tooling Work Board Sep 28, 2024
@david-waltermire
Copy link
Contributor

david-waltermire commented Sep 28, 2024 •
edited
Loading

Would it make sense to implement the following all at once?

I'd suggest skipping the collation variants of these functions. There is no support for collations yet and this would be a significant lift.

@aj-stein-gsa
Copy link
Contributor Author

Sure I just wanted to do it this weekend or early next week to keep myself sharp. Adjust the issue?

@aj-stein-gsa aj-stein-gsa changed the title Function substring-after() is not implemented in Metapath processor Function substring-* functions are not implemented in Metapath processor Sep 30, 2024
@aj-stein-gsa aj-stein-gsa changed the title Function substring-* functions are not implemented in Metapath processor Function substring- functions are not implemented in Metapath processor Sep 30, 2024
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Sep 30, 2024
@aj-stein-gsa
fn:string, add basic all param test for metaschema-framework#132
5c4477e
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Sep 30, 2024
@aj-stein-gsa
fn:string, primitive fn impl and register it metaschema-framework#132
34e4d68
@aj-stein-gsa aj-stein-gsa mentioned this issue Sep 30, 2024
Merged
7 tasks
@aj-stein-gsa aj-stein-gsa moved this from Ready to In progress in Tooling Work Board Sep 30, 2024
@david-waltermire david-waltermire linked a pull request Oct 5, 2024 that will close this issue
Add fn:substring to Metapath function library #142
Merged
7 tasks
@david-waltermire david-waltermire removed a link to a pull request Oct 5, 2024
Add fn:substring to Metapath function library #142
Merged
7 tasks
@david-waltermire david-waltermire linked a pull request Oct 5, 2024 that will close this issue
Add fn:substring to Metapath function library #142
Merged
7 tasks
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 6, 2024
@aj-stein-gsa
fn:string, add basic all param test for metaschema-framework#132
ed31e77
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 6, 2024
@aj-stein-gsa
fn:string, primitive fn impl and register it metaschema-framework#132
a712bd9
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 6, 2024
@aj-stein-gsa
Implement 2 and 3-arg fn sig builders for metaschema-framework#132
700d7ec
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 6, 2024
@aj-stein-gsa
Woops, execute correct typo in execute fn for metaschema-framework#132
cb16b5d
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 6, 2024
@aj-stein-gsa
Match int->Decimal argument types for metaschema-framework#132
0ac07ce 
We fixed some of that in early PR review, the function signatures will
obviously need those corrected too.
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 6, 2024
@aj-stein-gsa
Return empty String sequence in kind for in metaschema-framework#132
a2691c3
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
[WIP] Array offsets are the devil learned in metaschema-framework#132
9dedcd1
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
fn:string, add basic all param test for metaschema-framework#132
23a5c8c
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
fn:string, primitive fn impl and register it metaschema-framework#132
67ea6c9
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Implement 2 and 3-arg fn sig builders for metaschema-framework#132
42905c9
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Woops, execute correct typo in execute fn for metaschema-framework#132
89fc5f1
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Match int->Decimal argument types for metaschema-framework#132
a83404f 
We fixed some of that in early PR review, the function signatures will
obviously need those corrected too.
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Return empty String sequence in kind for in metaschema-framework#132
ab628ef
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
[WIP] Array offsets are the devil learned in metaschema-framework#132
c1d63fd
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
fn:string, add basic all param test for metaschema-framework#132
94f8aaa
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
fn:string, primitive fn impl and register it metaschema-framework#132
467cc80
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Implement 2 and 3-arg fn sig builders for metaschema-framework#132
c2dc954
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Woops, execute correct typo in execute fn for metaschema-framework#132
a69acc7
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Match int->Decimal argument types for metaschema-framework#132
b2ca01e 
We fixed some of that in early PR review, the function signatures will
obviously need those corrected too.
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Return empty String sequence in kind for in metaschema-framework#132
ba5002d
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
[WIP] Array offsets are the devil learned in metaschema-framework#132
9eb4e78
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 8, 2024
@aj-stein-gsa
Correct comments to substring spec refs for metaschema-framework#132
a917c91
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 20, 2024
@aj-stein-gsa
Add string-before impl and tests for metaschema-framework#132
ee46e63
@aj-stein-gsa aj-stein-gsa mentioned this issue Oct 20, 2024
Merged
7 tasks
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 20, 2024
@aj-stein-gsa
Add substring-after impl and tests for metaschema-framework#132
c4dd7f6
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 20, 2024
@aj-stein-gsa
Make before impl like after, fix up docs for metaschema-framework#132
bdd8cb8
@aj-stein-gsa aj-stein-gsa mentioned this issue Oct 20, 2024
Merged
7 tasks
@aj-stein-gsa aj-stein-gsa moved this from In progress to In review in Tooling Work Board Oct 20, 2024
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 20, 2024
@aj-stein-gsa
Fix equality check for empty args per metaschema-framework#132 review
3df4489
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Oct 20, 2024
@aj-stein-gsa
Fix equality check for empty args per metaschema-framework#132 review
e6bc547
david-waltermire pushed a commit that referenced this issue Oct 20, 2024
@aj-stein-gsa
Add substring-after impl to Metapath default function registry (#195)
1b54892 
* Add substring-after impl and tests for #132
david-waltermire pushed a commit that referenced this issue Oct 20, 2024
@aj-stein-gsa
Add substring-before() implementation (#194)
ebdf350 
* Add string-before impl and tests for #132
@github-project-automation github-project-automation bot moved this from In review to Done in Tooling Work Board Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aj-stein-gsa aj-stein-gsa

Labels
enhancement New feature or request java Pull requests that update Java code
Projects
Tooling Work Board
Archived in project
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Add fn:substring to Metapath function library aj-stein-gsa/metaschema-java
2 participants
@david-waltermire @aj-stein-gsa