Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish built-in deployment scripts #29

Closed
dtantsur opened this issue Apr 3, 2024 · 4 comments · Fixed by #54
Closed

Finish built-in deployment scripts #29

dtantsur opened this issue Apr 3, 2024 · 4 comments · Fixed by #54
Assignees
@matthewei
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@dtantsur
Copy link
Member

dtantsur commented Apr 3, 2024

Currently, the deployment scripts are an auto-generated mess. In particular, TLS support is commented out, preventing us from using webhooks. This all has to be cleaned up, TLS and webhook support enabled, redundant generated code removed.
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Apr 3, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Apr 3, 2024

/triage accepted
/lifecycle frozen
/help

@metal3-io-bot
Copy link
Contributor

@dtantsur:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/lifecycle frozen
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 3, 2024
@dtantsur dtantsur mentioned this issue Apr 3, 2024
Closed
@matthewei
Copy link

Please assign it to me!

@dtantsur
Copy link
Member Author

I think you can use /assign to assign yourself.

/assign @matthewei

dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Oct 28, 2024
@dtantsur
Clean-up configuration manifests (fixes metal3-io#29)
45f514e 
- Use the published image by default
- Enable cert-manager support by default
- Re-enable the webhook port and webhook manifests
- Fix deprecation warnings in kustomizations

Requires:
- metal3-io#53

Signed-off-by: Dmitry Tantsur <[email protected]>
@dtantsur dtantsur mentioned this issue Oct 29, 2024
Merged
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Oct 29, 2024
@dtantsur
Clean-up configuration manifests (fixes metal3-io#29)
fcfcba2 
- Use the published image by default
- Enable cert-manager support by default
- Re-enable the webhook port and webhook manifests
- Fix deprecation warnings in kustomizations

Requires:
- metal3-io#53

Signed-off-by: Dmitry Tantsur <[email protected]>
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Oct 29, 2024
@dtantsur
Clean-up configuration manifests (fixes metal3-io#29)
31f0b82 
- Use the published image by default
- Enable cert-manager support by default
- Re-enable the webhook port and webhook manifests
- Fix deprecation warnings in kustomizations

Requires:
- metal3-io#53

Signed-off-by: Dmitry Tantsur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewei matthewei

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean-up configuration manifests dtantsur/ironic-standalone-operator
3 participants
@dtantsur @metal3-io-bot @matthewei