Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baremetal node deprovisioning confirm #1849

Open
shibaPuppy opened this issue Jul 18, 2024 · 6 comments
Open

Add baremetal node deprovisioning confirm #1849

shibaPuppy opened this issue Jul 18, 2024 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@shibaPuppy
Copy link
Contributor

User Story

As a [developer/user/operator] I would like to [high level description] for [reasons]
If an operator accidentally reduces the replicas of a machine deployment, many nodes will be deprovisioned at once.

Detailed Description

[A clear and concise description of what you want to happen.]
CAPM3 is a special controller because it controls baremetal nodes.
If the machine is deleted due to a user's mistake, CAPM3 modifies the resources of the bmh and deprovisions the baremetal node.
At this time, it would be good to have a branch that checks whether to remove the dperovisioning image field by checking the value of bmh metadata.label.remove=true by checking an environment variable such as CAPM3_AUTO_REMOVE=true.

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind feature

@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jul 18, 2024
@metal3-io-bot
Copy link
Contributor

This issue is currently awaiting triage.
If Metal3.io contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rozzii
Copy link
Member

Rozzii commented Jul 24, 2024

Have you tried to use finalizers to block machine deletion? But in any case could you please explain in more detail what do you mean by this:
"At this time, it would be good to have a branch that checks whether to remove the dperovisioning image field by checking the value of bmh metadata.label.remove=true by checking an environment variable such as CAPM3_AUTO_REMOVE=true."

@Rozzii
Copy link
Member

Rozzii commented Jul 24, 2024

/triage needs-information

@metal3-io-bot metal3-io-bot added the triage/needs-information Indicates an issue needs more information in order to work on it. label Jul 24, 2024
@dtantsur
Copy link
Member

Also note: if you allow a BMH instance to get orphaned, how do you recover from this situation? Especially for users that do not have access to BMH CR's?

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2024
@Rozzii
Copy link
Member

Rozzii commented Oct 23, 2024

@shibaPuppy FYI this Issue is now stale, please provide the requested information otherwise the issue will be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

4 participants