Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PCI address information to BMH status.hardwareData #1823

Open
alknopfler opened this issue Jul 11, 2024 · 4 comments
Open

Add PCI address information to BMH status.hardwareData #1823

alknopfler opened this issue Jul 11, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@alknopfler
Copy link

User Story

As a user I would like to have access to PCI address information to be able to pre-configure pci accelerator cards (like acc100), e.g cluster hardware information can be used at the deployment phase to optimally configure workloads such as telco network functions.

Detailed Description

IPA is retrieving the pci address info included in /sys/bus/pci/devices but only the nics and disk are shown in the bmh object:
https://github.com/openstack/ironic-python-agent/blob/e9c0578c7d30ae97ad01ea52029cb7368433c0dc/ironic_python_agent/inspector.py#L339

So when the related information is available it would be good to propagate it to the BMH status.hardwareData

/kind feature

@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jul 11, 2024
@dtantsur
Copy link
Member

BMH status.hardwareData

is deprecated, any new additions should go to the separate HardwareData CR.

I don't object to this addition, but we need a proper discussion around the API we introduce and the user story we implement with it. Ideally, a design proposal.

@Rozzii
Copy link
Member

Rozzii commented Jul 24, 2024

/triage accepted
Accepted with the same caveat as in @dtantsur 's comment.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jul 24, 2024
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2024
@Rozzii
Copy link
Member

Rozzii commented Oct 23, 2024

/remove-lifecycle stale
Feature request is still valid, but no one seems to be interested to implement it yet
/lifecycle frozen

@metal3-io-bot metal3-io-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants