Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootMACAddress optional #1766

Open
hardys opened this issue Jun 4, 2024 · 4 comments
Open

Make bootMACAddress optional #1766

hardys opened this issue Jun 4, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@hardys
Copy link
Member

hardys commented Jun 4, 2024

User Story

As a user deploying only with virtualmedia I would like to omit bootMACAddress from my BMH definitions, so I can simplify the definition and reduce the pre-requisite information needed from the environment.

Detailed Description

Historically there have been issues which meant Ironic required the bootMACAddress even for non-PXE deployments handled via VirtualMedia (where in theory we shouldn't need any host network information).

Recent discussion on Slack with @dtantsur indicates we may be able to remove this restriction now given changes in Ironic since the original bootMACAddress API decision.

We should identify the relevant Ironic changes which remove the need for this information, then test on baremetal to ensure it's safe to make this field optional, and if so adjust the BMH schema to avoid requiring this information in all cases.

/kind feature

@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jun 4, 2024
@dtantsur
Copy link
Member

dtantsur commented Jun 4, 2024

Recent discussion on Slack with @dtantsur indicates we may be able to remove this restriction now given changes in Ironic since the original bootMACAddress API decision.

To be more precise, the Redfish driver in Ironic now tries to enroll ports (= NIC's) using Redfish before starting the full inspection. This makes BootMACAddress automatically available to Ironic. Caveats:

  1. In rare cases, the EthernetInterface resources are not implemented in Redfish
  2. If inspection is disabled, this workaround won't take place.

I have written a proposal https://bugs.launchpad.net/ironic/+bug/2049913 that suggests rethinking the whole inspection process, but I don't have any time to work on it.

@Rozzii
Copy link
Member

Rozzii commented Jun 12, 2024

/triage accepted
I am fine with this, this might cause some initial confusion for some users because the PXE booting will require a field that the Redfish won't + the rare cases @dtantsur mentioned, but I can live with that.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jun 12, 2024
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2024
@Rozzii
Copy link
Member

Rozzii commented Sep 11, 2024

/remove-lifecycle stale
/lifecycle frozen

@metal3-io-bot metal3-io-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Status: Backlog
Development

No branches or pull requests

4 participants