From 1a4ac656a648f3e43c50053f5771a52bfc0db1a8 Mon Sep 17 00:00:00 2001 From: Dmitry Tantsur Date: Mon, 25 Nov 2024 13:09:12 +0100 Subject: [PATCH] Do not add colons to structured logging It does not work by concatenating strings. This reverts commit 3a4cabbe135b6f392085ec6272f42ab4b6cefa14. Signed-off-by: Dmitry Tantsur --- controllers/metal3.io/baremetalhost_controller.go | 2 +- controllers/metal3.io/bmceventsubscription_controller.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/controllers/metal3.io/baremetalhost_controller.go b/controllers/metal3.io/baremetalhost_controller.go index ccd8aff277..509e9cd8b6 100644 --- a/controllers/metal3.io/baremetalhost_controller.go +++ b/controllers/metal3.io/baremetalhost_controller.go @@ -224,7 +224,7 @@ func (r *BareMetalHostReconciler) Reconcile(ctx context.Context, request ctrl.Re msg = err.Error() } provisionerNotReady.Inc() - reqLogger.Info("provisioner is not ready", "Error:", msg, "RequeueAfter:", provisionerNotReadyRetryDelay) + reqLogger.Info("provisioner is not ready", "Error", msg, "RequeueAfter", provisionerNotReadyRetryDelay) return ctrl.Result{Requeue: true, RequeueAfter: provisionerNotReadyRetryDelay}, nil } diff --git a/controllers/metal3.io/bmceventsubscription_controller.go b/controllers/metal3.io/bmceventsubscription_controller.go index 934eb81089..6528b0f574 100644 --- a/controllers/metal3.io/bmceventsubscription_controller.go +++ b/controllers/metal3.io/bmceventsubscription_controller.go @@ -107,7 +107,7 @@ func (r *BMCEventSubscriptionReconciler) Reconcile(ctx context.Context, request } else { msg = err.Error() } - reqLogger.Info("provisioner is not ready", "Error:", msg, "RequeueAfter:", provisionerNotReadyRetryDelay) + reqLogger.Info("provisioner is not ready", "Error", msg, "RequeueAfter", provisionerNotReadyRetryDelay) return ctrl.Result{RequeueAfter: provisionerNotReadyRetryDelay}, nil } @@ -229,7 +229,7 @@ func (r *BMCEventSubscriptionReconciler) getProvisioner(ctx context.Context, req } else { msg = err.Error() } - reqLogger.Info("provisioner is not ready", "Error:", msg, "RequeueAfter:", provisionerNotReadyRetryDelay) + reqLogger.Info("provisioner is not ready", "Error", msg, "RequeueAfter", provisionerNotReadyRetryDelay) return prov, ready, nil }