Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microstutters on the 2018-08-16 Build #6

Open
Hal47 opened this issue Sep 26, 2018 · 2 comments
Open

Microstutters on the 2018-08-16 Build #6

Hal47 opened this issue Sep 26, 2018 · 2 comments
Assignees
Labels
performance PtDE Prepare to Die Edition (32-bit)

Comments

@Hal47
Copy link

Hal47 commented Sep 26, 2018

I would like to let you know there seem to be constant microstutters while using this mod. This does not happen when using older releases of the mod, using the same machine, in the same savefile, under the same configuration. Logic dictates that it must be something new in the latest build.

@SeanPesce SeanPesce added the PtDE Prepare to Die Edition (32-bit) label Sep 26, 2018
@SeanPesce
Copy link
Collaborator

SeanPesce commented Sep 26, 2018

Thanks for the bug report! I haven't had time to work on the project recently so I appreciate that you isolated the source of the issue to a specific build. I'll look into it when I can.

@metal-crow
Copy link
Owner

@SeanPesce OTTOMH, i would hazard a guess it's a similar issue i ran into, to do with the runtime calls to GameData functions (like Game::get_node_count). These functions do a bunch of chain de-references which will usually end up hitting main memory, and can definitely cause stutters. I ended up fixing this in Remastered branch by implementing a caching systems for these calls that's refreshed every loading screen, may want to port that over to PTDE.

@SeanPesce SeanPesce self-assigned this Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance PtDE Prepare to Die Edition (32-bit)
Projects
None yet
Development

No branches or pull requests

3 participants