Skip to content

Commit 8218bce

Browse files
metagentometagento
committed
Fix compatible issues with Magento 2.3
1 parent 5156549 commit 8218bce

File tree

3 files changed

+78
-53
lines changed

3 files changed

+78
-53
lines changed

‎Setup/InstallSchema.php

Lines changed: 76 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -31,59 +31,84 @@ public function install(
3131
* Create table 'newsletterdiscountpro_program'
3232
*/
3333
$table = $installer->getConnection()
34-
->newTable($installer->getTable('newsletterdiscountpro_program'))
35-
->addColumn(
36-
'program_id', Table::TYPE_INTEGER, null,
37-
['identity' => true, 'nullable' => false, 'primary' => true, 'auto_increment' => true]
38-
)
39-
->addColumn(
40-
'from_date', Table::TYPE_DATETIME, null,
41-
['nullable' => true]
42-
)
43-
->addColumn(
44-
'to_date', Table::TYPE_DATETIME, null,
45-
['nullable' => true]
46-
)
47-
->addColumn(
48-
'number_order', Table::TYPE_INTEGER, null,
49-
['nullable' => false, 'default' => 0]
50-
)
51-
->addColumn(
52-
'use_coupon', Table::TYPE_INTEGER, 3,
53-
['nullable' => false, 'default' => 0]
54-
)
55-
->addColumn(
56-
'coupon_code', Table::TYPE_TEXT, null,
57-
['nullable' => false, 'default' => '']
58-
)
59-
->addColumn(
60-
'discount_type', Table::TYPE_TEXT, 100,
61-
['nullable' => false, 'default' => '']
62-
)
63-
->addColumn(
64-
'discount_value', Table::TYPE_DECIMAL, null,
65-
['nullable' => false, 'default' => 0]
66-
)
67-
->addColumn(
68-
'discount_on', Table::TYPE_TEXT, 100,
69-
['nullable' => false, 'default' => '']
70-
)
71-
->addColumn(
72-
'created_at', Table::TYPE_DATETIME, null,
73-
['nullable' => false]
74-
)
75-
->addColumn(
76-
'priority', Table::TYPE_INTEGER, null,
77-
['nullable' => false]
78-
);
34+
->newTable($installer->getTable('newsletterdiscountpro_program'))
35+
->addColumn(
36+
'program_id', Table::TYPE_INTEGER, null,
37+
['identity' => true, 'nullable' => false, 'primary' => true, 'auto_increment' => true],
38+
"Program Id"
39+
)
40+
->addColumn(
41+
'from_date', Table::TYPE_DATETIME, null,
42+
['nullable' => true],
43+
"From Date"
44+
)
45+
->addColumn(
46+
'to_date', Table::TYPE_DATETIME, null,
47+
['nullable' => true],
48+
"To Date"
49+
)
50+
->addColumn(
51+
'number_order', Table::TYPE_INTEGER, null,
52+
['nullable' => false, 'default' => 0],
53+
"Number Order"
54+
)
55+
->addColumn(
56+
'use_coupon', Table::TYPE_INTEGER, 3,
57+
['nullable' => false, 'default' => 0],
58+
"User Coupon"
59+
)
60+
->addColumn(
61+
'coupon_code', Table::TYPE_TEXT, null,
62+
['nullable' => false, 'default' => ''],
63+
"Coupon Code"
64+
)
65+
->addColumn(
66+
'discount_type', Table::TYPE_TEXT, 100,
67+
['nullable' => false, 'default' => ''],
68+
"Discount Type"
69+
)
70+
->addColumn(
71+
'discount_value', Table::TYPE_DECIMAL, null,
72+
['nullable' => false, 'default' => 0],
73+
"Discount Value"
74+
)
75+
->addColumn(
76+
'discount_on', Table::TYPE_TEXT, 100,
77+
['nullable' => false, 'default' => ''],
78+
"Discount On"
79+
)
80+
->addColumn(
81+
'created_at', Table::TYPE_DATETIME, null,
82+
['nullable' => false],
83+
"Created At"
84+
)
85+
->addColumn(
86+
'priority', Table::TYPE_INTEGER, null,
87+
['nullable' => false],
88+
"Priority"
89+
);
7990
$installer->getConnection()->createTable($table);
8091

81-
$installer->getConnection()->addColumn($setup->getTable('sales_order'), 'newsletter_discount', 'DECIMAL(10,2) NOT NULL DEFAULT 0');
82-
$installer->getConnection()->addColumn($setup->getTable('sales_order'), 'base_newsletter_discount', 'DECIMAL(10,2) NOT NULL DEFAULT 0');
83-
$installer->getConnection()->addColumn($setup->getTable('sales_invoice'), 'newsletter_discount', 'DECIMAL(10,2) NOT NULL DEFAULT 0');
84-
$installer->getConnection()->addColumn($setup->getTable('sales_invoice'), 'base_newsletter_discount', 'DECIMAL(10,2) NOT NULL DEFAULT 0');
85-
$installer->getConnection()->addColumn($setup->getTable('sales_creditmemo'), 'newsletter_discount', 'DECIMAL(10,2) NOT NULL DEFAULT 0');
86-
$installer->getConnection()->addColumn($setup->getTable('sales_creditmemo'), 'base_newsletter_discount', 'DECIMAL(10,2) NOT NULL DEFAULT 0');
92+
$columnDefination = [
93+
"type" => \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
94+
"length" => "12,4",
95+
"nullable" => false,
96+
"default" => 0,
97+
"comment" => "Newsletter Discount"
98+
];
99+
100+
$installer->getConnection()->addColumn($setup->getTable('sales_order'), 'newsletter_discount',
101+
$columnDefination);
102+
$installer->getConnection()->addColumn($setup->getTable('sales_order'), 'base_newsletter_discount',
103+
$columnDefination);
104+
$installer->getConnection()->addColumn($setup->getTable('sales_invoice'), 'newsletter_discount',
105+
$columnDefination);
106+
$installer->getConnection()->addColumn($setup->getTable('sales_invoice'), 'base_newsletter_discount',
107+
$columnDefination);
108+
$installer->getConnection()->addColumn($setup->getTable('sales_creditmemo'), 'newsletter_discount',
109+
$columnDefination);
110+
$installer->getConnection()->addColumn($setup->getTable('sales_creditmemo'), 'base_newsletter_discount',
111+
$columnDefination);
87112

88113
$installer->endSetup();
89114
return;

‎composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"license": [
99
"OSL-3.0"
1010
],
11-
"version" : "1.2.0",
11+
"version" : "1.3.0",
1212
"authors": [
1313
{
1414
"name": "metagento",

‎etc/module.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
33
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
4-
<module name="Metagento_NewsletterDiscountPro" setup_version="1.2.0"/>
4+
<module name="Metagento_NewsletterDiscountPro" setup_version="1.3.0"/>
55
</config>

0 commit comments

Comments
 (0)