-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari images with srcset not showing #732
Comments
Thanks for reporting this issue. This is actually two separate issues that we're both tracking.
I'm closing this issue here. Please follow those issues. |
Are those issues related? I couldn't find much information regarding this exact issue. This is happening to me without masonry or imagesLoaded - only Infinite Scroll. It seems images with srcset simply aren't displayed in Safari if they're loaded via Infinite Scroll. |
Same here. Not using imagesLoaded or Masonry. The height of appended images is being set to 0 if img height is set to auto in the CSS. Disabling the Wordpress srcset feature or removing height auto fixes this but both are far from ideal. |
Hello @fabianjaehnke, @tomusborne, @lsloss, I found a solution for this issue. I just take the width and height attributes of the items and add them in JS, like this:
It is not a perfect solution but that fix the Safari issue :) |
Another option that seems to work for me is to force the images to be parsed again after they are loaded:
|
Hello @nboliver, even better :) |
Weird issue… not sure why it is happening, but I had to deal with it today. @nboliver good "fix" 👍 |
I just had the same issue and the above suggestions didn't work for me, what I did is calculate the image and height before they load and set height and width with js:
|
http://www.besau-marguerre.de/
on this wordpress site the images do not show up if they have a srcset set.
The text was updated successfully, but these errors were encountered: