Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Malli schemas #24

Closed
tsmacdonald opened this issue Apr 29, 2024 · 1 comment · Fixed by #111
Closed

Add Malli schemas #24

tsmacdonald opened this issue Apr 29, 2024 · 1 comment · Fixed by #111
Assignees
@crisptrutski
Labels
developer experience Make developer's lives better good first issue Good for newcomers

Comments

@tsmacdonald
Copy link
Contributor

Bryan made the cogent suggestion to add Malli schemas to function metadata as a means of documentation and we've been planning for a while to Malli-fy everything. All public functions and constants should have schemas.
@tsmacdonald tsmacdonald added the good first issue Good for newcomers label Apr 29, 2024
@tsmacdonald tsmacdonald mentioned this issue Apr 29, 2024
Merged
@crisptrutski crisptrutski changed the title Add schemas Add Malli schemas May 23, 2024
@crisptrutski
Copy link
Collaborator

The schemas are starting to get quite wild, so we should consider doing this soon.

@crisptrutski crisptrutski added the developer experience Make developer's lives better label Jun 19, 2024
@crisptrutski crisptrutski self-assigned this Oct 25, 2024
@crisptrutski crisptrutski mentioned this issue Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisptrutski crisptrutski

Labels
developer experience Make developer's lives better good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Malli types for the public API metabase/macaw
2 participants
@tsmacdonald @crisptrutski