New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate tests/client-sdk and providers/tests #652

Open

yanxi0830 opened this issue Dec 18, 2024 · 0 comments

Assignees

Contributor

yanxi0830 commented Dec 18, 2024

🚀 Describe the new functionality needed

See prerequisite issue in: Higher test coverage for tests/client-sdk #651

Why

We currently use providers/tests (to test impls) and tests/client-sdk to test SDK (via directClient & httpClient)
We don't want to maintain 2 sets of tests and consolidate to a single suite of tests

What

Audit existing tests on functionalities in providers/tests
Merge providers/tests with tests/client-sdk

Code Pointer

tests/client-sdk: https://github.com/meta-llama/llama-stack/tree/main/tests/client-sdk
providers/tests: https://github.com/meta-llama/llama-stack/tree/main/llama_stack/providers/tests

💡 Why is this needed? What if we don't build it?

Reliability

Other thoughts

No response

yanxi0830 assigned vladimirivic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment