Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation of Sampling Param semantics in documentation #602

Open
mattf opened this issue Dec 11, 2024 · 1 comment
Open

Explanation of Sampling Param semantics in documentation #602

mattf opened this issue Dec 11, 2024 · 1 comment

Comments

@mattf
Copy link
Contributor

mattf commented Dec 11, 2024

🚀 Describe the new functionality needed

Sampling params semantics

  • strategy: greedy | top_k | top_p
  • temperature: Optional[float] = 0.0
  • top_p: Optional[float] = 0.95
  • top_k: Optional[int] = 0

How does strategy relate to temperature / top_p / top_k?

What are the semantics when a user provides combinations of temperature / top_p / top_k?

💡 Why is this needed? What if we don't build it?

Users need to understand the impact of the SamplingParams on their inference requests.

Other thoughts

No response

@aidando73
Copy link
Contributor

+1 - useful for us contributors as well so we know how the apis should be behaving. E.g., when adding a new provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants