Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

union types have the union name included in the final type name #34

Open
dineshyv opened this issue Nov 15, 2024 · 1 comment
Open

union types have the union name included in the final type name #34

dineshyv opened this issue Nov 15, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@dineshyv
Copy link
Contributor

TaskConfigBenchmarkEvalTaskConfig is an example of the type thats generated by stainless for
EvalTaskConfig = Annotated[
Union[BenchmarkEvalTaskConfig, AppEvalTaskConfig], Field(discriminator="type")
]

cc: @yanxi0830 @ashwinb

@dineshyv dineshyv added the help wanted Extra attention is needed label Nov 15, 2024
@ashwinb
Copy link
Contributor

ashwinb commented Nov 15, 2024

I think we need to simplify these types / find a pattern to rename it so they are not enormous like that. @subramen had also raised this issue earlier. It is pretty high-pri to get resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants