Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react scan debugging #469

Merged

Conversation

danditomaso
Copy link
Collaborator

@danditomaso danditomaso commented Feb 26, 2025

Description

This PR introduces React Scan to our development workflow. React Scan is a static analysis tool that helps identify performance issues, accessibility problems, and potential render bugs in React components before they reach production.

Changes Made

  • Identify components with unnecessary re-renders
  • Detect potential memory leaks from improper hook usage
  • Find accessibility violations early in the development process

Screenshots (if applicable)

Screenshot 2025-02-26 at 2 25 26 pm Screenshot 2025-02-26 at 2 25 52 pm eab227" />

Copy link
Member

@KomelT KomelT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be smart to add an explanation of this command to the development section?

@danditomaso
Copy link
Collaborator Author

Would it be smart to add an explanation of this command to the development section?

Good idea, I could swear I pushed my readme changes earlier. In any case I added a commit with the details now, thanks for mentioning it 👍

@danditomaso danditomaso requested a review from KomelT February 27, 2025 01:50
@danditomaso danditomaso merged commit 593c08f into meshtastic:master Feb 27, 2025
3 checks passed
@danditomaso danditomaso deleted the feat/add-react-scan-debugging branch February 27, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants